Client side caching invalidations (standalone) #3089

dvora-h · 2023-12-23T21:39:13Z

Pull Request check-list

Please make sure to review and check all of these items:

Do tests and lints pass with this change?
Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
Is the new or changed code fully tested?
Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
Is there an example added to the examples folder (if applicable)?
Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

codecov-commenter · 2023-12-23T21:46:15Z

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (f6a4b49) 91.17% compared to head (5fd31c7) 91.49%.

Files	Patch %	Lines
redis/asyncio/client.py	86.27%	7 Missing ⚠️
redis/_parsers/resp3.py	80.64%	6 Missing ⚠️
redis/cache.py	80.00%	2 Missing ⚠️
redis/client.py	86.66%	2 Missing ⚠️
redis/cluster.py	0.00%	1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3089      +/-   ##
==========================================
+ Coverage   91.17%   91.49%   +0.31%     
==========================================
  Files         127      129       +2     
  Lines       32855    33062     +207     
==========================================
+ Hits        29956    30249     +293     
+ Misses       2899     2813      -86

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

redis/_parsers/resp3.py

redis/cache.py

redis/client.py

redis/asyncio/client.py

sjpotter · 2024-01-01T08:08:17Z

redis/_parsers/resp3.py

+    def handle_push_response(self, response, disable_decoding, push_request):
+        if response[0] in _INVALIDATION_MESSAGE:
+            res = self.invalidation_push_handler_func(response)
+        else:
+            res = self.pubsub_push_handler_func(response)
+        if not push_request:
+            return self._read_response(
+                disable_decoding=disable_decoding, push_request=push_request
+            )
+        else:
+            return res


I think it be better to test response[0] for pubsub as well (think its "message"?) and error out if its another type not supported.

if willing to force python 3.10, can use a switch/case/default stateent?

don't understand what pust_request is yet.

sjpotter · 2024-01-01T08:11:21Z

redis/_parsers/resp3.py

+    async def handle_push_response(self, response, disable_decoding, push_request):
+        if response[0] in _INVALIDATION_MESSAGE:
+            res = self.invalidation_push_handler_func(response)
+        else:
+            res = self.pubsub_push_handler_func(response)
+        if not push_request:
+            return await self._read_response(
+                disable_decoding=disable_decoding, push_request=push_request
+            )
+        else:
+            return res


confused why this logic seems to be duplicated from above?

* cache invalidations * isort * deamon thread * remove threads * delete comment * tests * skip if hiredis available * async * review comments * docstring * decode test * fix test * fix decode response test

dvora-h added 2 commits December 20, 2023 12:16

cache invalidations

ac282f2

isort

5638acb

dvora-h added feature New feature experimental labels Dec 23, 2023

dvora-h mentioned this pull request Dec 23, 2023

Retrieving invalidation message in redis-py when client tracking is used #3087

Closed

dvora-h added 6 commits December 24, 2023 13:07

deamon thread

494d1bc

remove threads

3cf4f14

delete comment

e5f2bba

tests

455e894

skip if hiredis available

814f78a

async

8dc575e

dvora-h changed the title ~~Client side caching invalidations (sync, standalone)~~ Client side caching invalidations (standalone) Dec 31, 2023