CSC Review Fixes - expose delete functions, rename attribute names, add AbstractCache class #3110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3110 +/- ##
==========================================
- Coverage 92.06% 91.74% -0.33%
==========================================
Files 128 128
Lines 33220 33320 +100
==========================================
- Hits 30583 30568 -15
- Misses 2637 2752 +115 ☔ View full report in Codecov by Sentry. |
chayim
reviewed
Jan 15, 2024
redis/_cache.py
Outdated
| @@ -160,7 +160,27 @@ class EvictionPolicy(Enum): | |||
| RANDOM = "random" | |||
|
|
|||
|
|
|||
| class _LocalCache: | |||
| class AbstractCache: | |||
There was a problem hiding this comment.
Let's docstring to help our users understand why and how to use it. Acorss functions
chayim
reviewed
Jan 15, 2024
redis/_cache.py
Outdated
| @@ -160,7 +160,27 @@ class EvictionPolicy(Enum): | |||
| RANDOM = "random" | |||
|
|
|||
|
|
|||
| class _LocalCache: | |||
| class AbstractCache: | |||
There was a problem hiding this comment.
WDYT: Have a look at Abstract base classes, and maybe inherit from ABC?
chayim
suggested changes
Jan 15, 2024
There was a problem hiding this comment.
This matches we we discussed with @vladvildanov and looks reasonable! Please consider making the cache truly abstract.
vladvildanov
approved these changes
Jan 15, 2024
chayim
approved these changes
Jan 15, 2024
vladvildanov
pushed a commit
that referenced
this pull request
Sep 27, 2024
…dd AbstractCache class (#3110) * CSC review fixes * cahnge cache_max_size default value * use ABC and add docstring
vladvildanov
pushed a commit
that referenced
this pull request
Sep 27, 2024
…dd AbstractCache class (#3110) * CSC review fixes * cahnge cache_max_size default value * use ABC and add docstring
vladvildanov
pushed a commit
that referenced
this pull request
Sep 27, 2024
…dd AbstractCache class (#3110) * CSC review fixes * cahnge cache_max_size default value * use ABC and add docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Please provide a description of the change here.