Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug: client side caching causes unexpected disconnections #3160

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Feb 26, 2024

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@dvora-h dvora-h added the bug Bug label Feb 26, 2024
@dvora-h dvora-h requested a review from chayim February 26, 2024 13:35
@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.85%. Comparing base (2f88840) to head (37861d5).
Report is 9 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3160      +/-   ##
==========================================
+ Coverage   91.84%   91.85%   +0.01%     
==========================================
  Files         128      128              
  Lines       33232    33300      +68     
==========================================
+ Hits        30523    30589      +66     
- Misses       2709     2711       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dvora-h dvora-h merged commit c573bc4 into redis:master Feb 28, 2024
43 of 44 checks passed
vladvildanov pushed a commit that referenced this pull request Sep 27, 2024
* fix disconnects

* skip test in cluster

---------

Co-authored-by: Chayim <chayim@users.noreply.github.com>
vladvildanov pushed a commit that referenced this pull request Sep 27, 2024
* fix disconnects

* skip test in cluster

---------

Co-authored-by: Chayim <chayim@users.noreply.github.com>
vladvildanov pushed a commit that referenced this pull request Sep 27, 2024
* fix disconnects

* skip test in cluster

---------

Co-authored-by: Chayim <chayim@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants