Hash field expiration commands #3218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tishun
reviewed
Apr 30, 2024
| gt: bool = False, | ||
| lt: bool = False, | ||
| ) -> ResponseT: | ||
| """ |
There was a problem hiding this comment.
BTW on the topic of docstrings : as mentioned by this discussion in Stackoverflow we can use the Pyment tool to generate new reST documentation or convert existing one from other formats. This is probably going to help in the general direction of consistency.
IMHO it is a good idea to continue with the reST format you are using here chiefly because of two things - we can generate documentation using Sphinx and it is generally recommended by PEP 287
There was a problem hiding this comment.
After trying out some more things, I think that the Google style documentation would be better suited. The main reason is that it supports bullet lists in a straightforward way. With reST I could not get a bullet list properly formatted in the PyCharm documentation popup.
Also it seems to me that a great deal of the existing documentation is a flavor of the Google style. It would be the least effort to convert it to the proper Google format.
And, after enabling the napoleon preprocessor for Sphinx, this Google style documentation also gets converted well (after some additional fine tuning related to typing).
Add support for the HGETF and HSETF commands. Also add extra checks to the other hash field expiration commands, and fix some typing hints.
vladvildanov
approved these changes
May 24, 2024
The Graph module is no longer part of Redis Stack, so for the moment disable all related tests.
gerzse
added a commit
to gerzse/redis-py
that referenced
this pull request
Jul 11, 2024
Support hash field expiration commands that become available with Redis 7.4. Adapt some tests to match recent server-side changes. Update tests related to memory stats. Make CLIENT KILL test not run with cluster. Disable tests related to Graph module. The Graph module is no longer part of Redis Stack, so for the moment disable all related tests. --------- Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com>
gerzse
added a commit
that referenced
this pull request
Jul 11, 2024
Support hash field expiration commands that become available with Redis 7.4. Adapt some tests to match recent server-side changes. Update tests related to memory stats. Make CLIENT KILL test not run with cluster. Disable tests related to Graph module. The Graph module is no longer part of Redis Stack, so for the moment disable all related tests. --------- Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com>
agnesnatasya
pushed a commit
to agnesnatasya/redis-py
that referenced
this pull request
Jul 20, 2024
Support hash field expiration commands that become available with Redis 7.4. Adapt some tests to match recent server-side changes. Update tests related to memory stats. Make CLIENT KILL test not run with cluster. Disable tests related to Graph module. The Graph module is no longer part of Redis Stack, so for the moment disable all related tests. --------- Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com>
vladvildanov
pushed a commit
that referenced
this pull request
Sep 27, 2024
Support hash field expiration commands that become available with Redis 7.4. Adapt some tests to match recent server-side changes. Update tests related to memory stats. Make CLIENT KILL test not run with cluster. Disable tests related to Graph module. The Graph module is no longer part of Redis Stack, so for the moment disable all related tests. --------- Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com>
vladvildanov
pushed a commit
that referenced
this pull request
Sep 27, 2024
Support hash field expiration commands that become available with Redis 7.4. Adapt some tests to match recent server-side changes. Update tests related to memory stats. Make CLIENT KILL test not run with cluster. Disable tests related to Graph module. The Graph module is no longer part of Redis Stack, so for the moment disable all related tests. --------- Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com>
vladvildanov
pushed a commit
that referenced
this pull request
Sep 27, 2024
Support hash field expiration commands that become available with Redis 7.4. Adapt some tests to match recent server-side changes. Update tests related to memory stats. Make CLIENT KILL test not run with cluster. Disable tests related to Graph module. The Graph module is no longer part of Redis Stack, so for the moment disable all related tests. --------- Co-authored-by: Gabriel Erzse <gabriel.erzse@redis.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Hash field expiration commands