Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable Graph tests #3287

Merged
merged 6 commits into from
Jun 20, 2024
Merged

Re-enable Graph tests #3287

merged 6 commits into from
Jun 20, 2024

Conversation

gerzse
Copy link
Contributor

@gerzse gerzse commented Jun 19, 2024

Although the Graph module was deprecated, we want to have tests running as long as we keep the client code. So re-enable the Graph tests, by adding to the docker-compose stack a redis-stack-server container with an older version.

Tweak the CI so that it runs against the latest RC release for now, in order to have all tests executed, including the ones for hash field expiration.

Take the opportunity to mark all tests related to TimeSeries as modules tests.

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@gerzse
Re-enable Graph tests
c2ff5b8 
Although the Graph module was deprecated, we want to have tests running
as long as we keep the client code. So re-enable the Graph tests, by
adding to the docker-compose stack a redis-stack-server container with
an older version.

Tweak the CI so that it runs against the latest RC release for now, in
order to have all tests executed, including the ones for hash field
expiration.

Take the opportunity to mark all tests related to TimeSeries as modules
tests.
@gerzse gerzse added the maintenance Maintenance (CI, Releases, etc) label Jun 19, 2024
@gerzse gerzse requested a review from vladvildanov June 19, 2024 12:44
@gerzse gerzse merged commit 12b040e into redis:master Jun 20, 2024
44 checks passed
gerzse added a commit to gerzse/redis-py that referenced this pull request Jul 11, 2024
@gerzse
Re-enable Graph tests (redis#3287)
927fd18 
Although the Graph module was deprecated, we want to have tests running
as long as we keep the client code. Therefore re-enable the Graph tests, by
adding to the docker-compose stack an older redis-stack-server image. The
Graph tests run only with RESP2.

Tweak the CI so that it runs against the latest RC release for now. This way
we get all the features in RC release of server, so we can execute all tests,
including the ones for hash field expiration.

Some test failures brought to light issues with the RESP3 push message
invalidation handler, align a bit the code in that area.

Some more housekeeping around tests, here and there.
gerzse added a commit that referenced this pull request Jul 11, 2024
@gerzse
Re-enable Graph tests (#3287)
338cbfd 
Although the Graph module was deprecated, we want to have tests running
as long as we keep the client code. Therefore re-enable the Graph tests, by
adding to the docker-compose stack an older redis-stack-server image. The
Graph tests run only with RESP2.

Tweak the CI so that it runs against the latest RC release for now. This way
we get all the features in RC release of server, so we can execute all tests,
including the ones for hash field expiration.

Some test failures brought to light issues with the RESP3 push message
invalidation handler, align a bit the code in that area.

Some more housekeeping around tests, here and there.
agnesnatasya pushed a commit to agnesnatasya/redis-py that referenced this pull request Jul 20, 2024
@gerzse @agnesnatasya
Re-enable Graph tests (redis#3287)
398a78c 
Although the Graph module was deprecated, we want to have tests running
as long as we keep the client code. Therefore re-enable the Graph tests, by
adding to the docker-compose stack an older redis-stack-server image. The
Graph tests run only with RESP2.

Tweak the CI so that it runs against the latest RC release for now. This way
we get all the features in RC release of server, so we can execute all tests,
including the ones for hash field expiration.

Some test failures brought to light issues with the RESP3 push message
invalidation handler, align a bit the code in that area.

Some more housekeeping around tests, here and there.
vladvildanov pushed a commit that referenced this pull request Sep 27, 2024
@gerzse @vladvildanov
Re-enable Graph tests (#3287)
ce62a37 
Although the Graph module was deprecated, we want to have tests running
as long as we keep the client code. Therefore re-enable the Graph tests, by
adding to the docker-compose stack an older redis-stack-server image. The
Graph tests run only with RESP2.

Tweak the CI so that it runs against the latest RC release for now. This way
we get all the features in RC release of server, so we can execute all tests,
including the ones for hash field expiration.

Some test failures brought to light issues with the RESP3 push message
invalidation handler, align a bit the code in that area.

Some more housekeeping around tests, here and there.
vladvildanov pushed a commit that referenced this pull request Sep 27, 2024
@gerzse @vladvildanov
Re-enable Graph tests (#3287)
7598278 
Although the Graph module was deprecated, we want to have tests running
as long as we keep the client code. Therefore re-enable the Graph tests, by
adding to the docker-compose stack an older redis-stack-server image. The
Graph tests run only with RESP2.

Tweak the CI so that it runs against the latest RC release for now. This way
we get all the features in RC release of server, so we can execute all tests,
including the ones for hash field expiration.

Some test failures brought to light issues with the RESP3 push message
invalidation handler, align a bit the code in that area.

Some more housekeeping around tests, here and there.
vladvildanov pushed a commit that referenced this pull request Sep 27, 2024
@gerzse @vladvildanov
Re-enable Graph tests (#3287)
fa995c9 
Although the Graph module was deprecated, we want to have tests running
as long as we keep the client code. Therefore re-enable the Graph tests, by
adding to the docker-compose stack an older redis-stack-server image. The
Graph tests run only with RESP2.

Tweak the CI so that it runs against the latest RC release for now. This way
we get all the features in RC release of server, so we can execute all tests,
including the ones for hash field expiration.

Some test failures brought to light issues with the RESP3 push message
invalidation handler, align a bit the code in that area.

Some more housekeeping around tests, here and there.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladvildanov vladvildanov vladvildanov approved these changes

Assignees
No one assigned
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gerzse @vladvildanov