Fixes CAE-333 #3290
Merged
Fixes CAE-333 #3290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
class did override the initialization of the socket_timeout parameter.
vladvildanov
approved these changes
Jun 25, 2024
| Addresses bug CAE-333 which uncovered that the init method of the base | ||
| class did override the initialization of the socket_timeout parameter. | ||
| ''' | ||
| def test_unix_socket_with_timeout(): |
There was a problem hiding this comment.
Two blank-lines required between function definition and doc-blocks, as well as after the test
vladvildanov
added a commit
that referenced
this pull request
Jun 25, 2024
* Fixes CAE-333, which uncovered that the init method of the base class did override the initialization of the socket_timeout parameter. * Added missing blank lines * Removed blank line * Changed to quotes --------- Co-authored-by: vladvildanov <divinez122@outlook.com>
Merged
vladvildanov
added a commit
that referenced
this pull request
Jun 26, 2024
* Fixes CAE-333 (#3290) * Fixes CAE-333, which uncovered that the init method of the base class did override the initialization of the socket_timeout parameter. * Added missing blank lines * Removed blank line * Changed to quotes --------- Co-authored-by: vladvildanov <divinez122@outlook.com> * Updated version in setup.py --------- Co-authored-by: David Maier <60782329+dmaier-redislabs@users.noreply.github.com>
agnesnatasya
pushed a commit
to agnesnatasya/redis-py
that referenced
this pull request
Jul 20, 2024
* Fixes CAE-333, which uncovered that the init method of the base class did override the initialization of the socket_timeout parameter. * Added missing blank lines * Removed blank line * Changed to quotes --------- Co-authored-by: vladvildanov <divinez122@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug uncovered that the init method of the base class did override the initialization of the socket_timeout parameter.
This was fixed by moving
super().__init__(**kwargs)before setting the timeout and path properties.In addition, a test case was added.