Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for ADDSCORES modifier #3329

Merged
merged 6 commits into from
Jul 30, 2024
Merged

Added support for ADDSCORES modifier #3329

merged 6 commits into from
Jul 30, 2024

Conversation

vladvildanov
Copy link
Collaborator

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

Description of change

Added support for new argument for FT.AGGREGATE command that will be present in RediSearch 2.10.5

@vladvildanov vladvildanov added the feature New feature label Jul 22, 2024
uglide
uglide requested changes Jul 26, 2024
View reviewed changes
tests/test_search.py Outdated Show resolved Hide resolved
tests/test_asyncio/test_search.py Outdated Show resolved Hide resolved
@vladvildanov vladvildanov merged commit fb74aa2 into master Jul 30, 2024
56 checks passed
@vladvildanov vladvildanov deleted the vv-hybrid-scoring branch July 30, 2024 12:00
vladvildanov added a commit that referenced this pull request Jul 30, 2024
@vladvildanov
Added support for ADDSCORES modifier (#3329)
e82c56e 
* Added support for ADDSCORES modifier

* Fixed codestyle issues

* More codestyle fixes

* Updated test cases and testing image to represent latest

* Codestyle issues

* Added handling for dict responses
vladvildanov added a commit that referenced this pull request Sep 27, 2024
@vladvildanov
Added support for ADDSCORES modifier (#3329)
b381b65 
* Added support for ADDSCORES modifier

* Fixed codestyle issues

* More codestyle fixes

* Updated test cases and testing image to represent latest

* Codestyle issues

* Added handling for dict responses
vladvildanov added a commit that referenced this pull request Sep 27, 2024
@vladvildanov
Added support for ADDSCORES modifier (#3329)
65dbae9 
* Added support for ADDSCORES modifier

* Fixed codestyle issues

* More codestyle fixes

* Updated test cases and testing image to represent latest

* Codestyle issues

* Added handling for dict responses
vladvildanov added a commit that referenced this pull request Sep 27, 2024
@vladvildanov
Added support for ADDSCORES modifier (#3329)
bc93b54 
* Added support for ADDSCORES modifier

* Fixed codestyle issues

* More codestyle fixes

* Updated test cases and testing image to represent latest

* Codestyle issues

* Added handling for dict responses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uglide uglide uglide approved these changes

@dmaier-redislabs dmaier-redislabs Awaiting requested review from dmaier-redislabs

Assignees
No one assigned
Labels
feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vladvildanov @uglide