-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typing for client __init__ #3357
base: master
Are you sure you want to change the base?
Conversation
@Vulwsztyn Tests are failing, cause of conditional OpenSSL dependency |
@vladvildanov thanks I'll make it unconditional |
@Vulwsztyn Thank you for your contribution! |
3771028
to
d6a4326
Compare
@vladvildanov I changed the typing to string literals so that it doesn't require imports and removed the conditional imports |
@vladvildanov Any insight as to why the tests are failing now? Should I do something? |
852adb5
to
c53e5e3
Compare
@vladvildanov I fixed the linting issues. Sorry it took so long.
|
c53e5e3
to
7644229
Compare
rebased unto master |
@Vulwsztyn OpenSSL is still an issue if you have a look in CI logs |
@vladvildanov Thanks for the ping. I don't get something here. In this line Line 870 in 7d73d74
import OpenSSL , but it is not a dependency of this project? Should it remain so?
|
f0339e7
to
4b76013
Compare
Removed the typing requiring openssl |
4b76013
to
5ac186a
Compare
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
I only added typings to
__init__
method ofclient:Redis
classI realise this exists: #3252
But there were some comments and it is dead since the end of May, while I hope this PR introduces so little change that it is instantly mergeable.