Skip to content

Commit

Permalink
chore: leave the todo note about clearing written command
Browse files Browse the repository at this point in the history
  • Loading branch information
rueian committed Sep 9, 2023
1 parent d5b8a10 commit c2ec5fb
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions resp.go
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,8 @@ func writeCmd(o *bufio.Writer, cmd []string) (err error) {
err = writeN(o, '*', len(cmd))
for _, m := range cmd {
err = writeB(o, '$', m)
// TODO: Can we set cmd[i] = "" here to allow GC to eagerly recycle memory?
// Related: https://github.com/redis/rueidis/issues/364
}
return err
}
Expand Down

0 comments on commit c2ec5fb

Please sign in to comment.