Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default filters #146

Merged
merged 5 commits into from
Jun 20, 2024
Merged

Default filters #146

merged 5 commits into from
Jun 20, 2024

Conversation

ac615223s5
Copy link
Contributor

@ac615223s5 ac615223s5 commented Jun 18, 2024

closes #137

@sigaloid
Copy link
Member

Is it just me, or do I not see any code that actually implements the filter? 🫣

@ac615223s5
Copy link
Contributor Author

ac615223s5 commented Jun 19, 2024

it's already implemented :D

@sigaloid
Copy link
Member

Where's the code that actually uses the value in the config, to filter out subs?

@ac615223s5
Copy link
Contributor Author

if let Some(default) = get_setting(&format!("REDLIB_DEFAULT_{}", name.to_uppercase())) {

@sigaloid
Copy link
Member

AH!!! It's the cookie-default type of setting. Always slips my mind. Thanks so much for the PR! Happy to merge once the clippy lint passes :)

@sigaloid sigaloid merged commit 2d5cfcb into redlib-org:main Jun 20, 2024
3 checks passed
@ac615223s5 ac615223s5 deleted the default-filter branch June 20, 2024 17:52
@zunjae
Copy link

zunjae commented Jul 24, 2024

A great feature that isn't advertised in the readme (unless im blind)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💡 Feature request: Default filters
3 participants