Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backend: do not base64 encode json payload in msgpack serde #1037

Merged
merged 1 commit into from
Jan 30, 2024
Merged

backend: do not base64 encode json payload in msgpack serde #1037

merged 1 commit into from
Jan 30, 2024

Conversation

bojand
Copy link
Member

@bojand bojand commented Jan 26, 2024

Fixes #1034.

image

@bojand bojand requested a review from weeco January 26, 2024 03:01
@skarrok
Copy link
Contributor

skarrok commented Jan 26, 2024

Thank you for a quick fix!

I checked out this branch and can confirm value shows up correctly and filtering by value fields just works.

However headers are still show up as text instead of being decoded as msgpack.

image

@bojand bojand self-assigned this Jan 26, 2024
@weeco weeco merged commit b56cb2b into master Jan 30, 2024
8 checks passed
@weeco weeco deleted the backend/msgpack_serde_fix branch January 30, 2024 10:53
@bojand bojand restored the backend/msgpack_serde_fix branch April 12, 2024 00:25
@bojand bojand deleted the backend/msgpack_serde_fix branch April 12, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weeco weeco weeco approved these changes

Assignees

@bojand bojand

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

msgpack filtering and display broken
3 participants
@bojand @skarrok @weeco