Fixes invalid regexp scenario #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| filteredSubjects = filteredSubjects.filter(x => uiSettings.schemaList.showSoftDeleted || (!uiSettings.schemaList.showSoftDeleted && !x.isSoftDeleted)) | ||
| .filter(x => x.name.toLowerCase().match(quickSearchRegExp)); | ||
| } catch (e) { | ||
| console.warn('Invalid expression') |
There was a problem hiding this comment.
Ideally we should handle or rethrow the error or capture the exception. Maybe we should also check that the regexp should run, if there is no uiSettings.schemaList.quickSearch for example?
There was a problem hiding this comment.
@malinskibeniamin based on what I found there is no other way to check whether regexp is valid other than trying to compose it and catch with an exception. IF it's valid, we filter on it, if it's not valid, we keep the original array.
malinskibeniamin
approved these changes
Feb 6, 2024
| const filteredSubjects = api.schemaSubjects | ||
| .filter(x => uiSettings.schemaList.showSoftDeleted || (!uiSettings.schemaList.showSoftDeleted && !x.isSoftDeleted)) | ||
| .filter(x => x.name.toLowerCase().match(quickSearchRegExp)); | ||
| let filteredSubjects = api.schemaSubjects |
malinskibeniamin
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.