Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit last page to the last existing page in the table #1121

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Limit last page to the last existing page in the table #1121

merged 1 commit into from
Feb 19, 2024

Conversation

jvorcak
Copy link
Collaborator

@jvorcak jvorcak commented Feb 16, 2024

Fixes #1104

@jvorcak jvorcak requested a review from rikimaru0345 February 16, 2024 09:57
@jvorcak
Copy link
Collaborator Author

jvorcak commented Feb 16, 2024

I'd appreciate if we try to test this properly before merging.

@jvorcak jvorcak marked this pull request as ready for review February 16, 2024 11:33
@malinskibeniamin
Copy link
Contributor

Changes look good. I will let console team approve

@jvorcak jvorcak merged commit a6264de into master Feb 19, 2024
6 checks passed
@jvorcak jvorcak deleted the fix/limit-page-to-last-existing branch February 19, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rikimaru0345 rikimaru0345 rikimaru0345 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resetting pagination if the result returns fewer pages
3 participants
@jvorcak @malinskibeniamin @rikimaru0345