Skip to content

Commit

Permalink
pandaproxy: add request_errors_total metric to interal metrics
Browse files Browse the repository at this point in the history
(cherry picked from commit 939face)
  • Loading branch information
IoannisRP committed Dec 17, 2024
1 parent 2f4b9c6 commit 0985073
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions src/v/pandaproxy/probe.cc
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ void probe::setup_metrics() {
const auto operation_label = make_label("operation", internal);
const auto agg = internal ? std::vector<sm::label>{sm::shard_label}
: std::vector<sm::label>{
sm::shard_label, operation_label};
sm::shard_label, operation_label};
const auto status = make_label("status", internal);
return {
.label = operation_label(_path.operations.nickname),
Expand Down Expand Up @@ -110,7 +110,10 @@ void probe::setup_metrics() {
if (!config::shard_local_cfg().disable_metrics()) {
_metrics.add_group(
"pandaproxy",
{make_internal_request_latency(internal_labels)},
{make_internal_request_latency(internal_labels),
make_request_errors_total_5xx(internal_labels),
make_request_errors_total_4xx(internal_labels),
make_request_errors_total_3xx(internal_labels)},
{},
internal_labels.agg);
}
Expand Down

0 comments on commit 0985073

Please sign in to comment.