Merge pull request #1167 from andresaristizabal/wasm/js/fix-crash-on-…

…invalid-coproc Wasm/js/fix crash on invalid coproc
redpanda-data · Apr 16, 2021 · 9b587f4 · 9b587f4
2 parents b93bd19 + 77748b9
commit 9b587f4
Showing 1 changed file with 7 additions and 11 deletions.
diff --git a/src/js/modules/rpc/server.ts b/src/js/modules/rpc/server.ts
@@ -196,17 +196,13 @@ export class ProcessBatchServer extends SupervisorServer {
       this.fireException
     );
 
-    return Promise.allSettled(results).then((coprocessorResults) => {
-      const array: ProcessBatchReplyItem[][] = [];
-      coprocessorResults.forEach((result) => {
-        if (result.status === "rejected") {
-          console.error(result.reason);
-        } else {
-          array.push(result.value);
-        }
-      });
-      return array.flat();
-    });
+    return Promise.all(results).then(
+      (coprocessorResults) => coprocessorResults.flat(),
+      (e) => {
+        this.logger.error(e);
+        return Logging.close().then(() => process.exit(1));
+      }
+    );
   }
 
   /**