Skip to content

Commit

Permalink
Merge pull request #24571 from WillemKauf/random_node_storage_type_fix
Browse files Browse the repository at this point in the history
`rptest`: fix `random_node_operations_test` parameterization
  • Loading branch information
piyushredpanda authored Dec 14, 2024
2 parents c1b5b93 + 3a5c67f commit be7d112
Showing 1 changed file with 13 additions and 5 deletions.
18 changes: 13 additions & 5 deletions tests/rptest/tests/random_node_operations_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
from rptest.utils.node_operations import FailureInjectorBackgroundThread, NodeOpsExecutor, generate_random_workload

from rptest.clients.offline_log_viewer import OfflineLogViewer
from rptest.tests.datalake.utils import supported_storage_types

TS_LOG_ALLOW_LIST = [
re.compile(
Expand Down Expand Up @@ -334,11 +335,18 @@ def test_node_operations(self, enable_failures, mixed_versions,
# tp-workload-deletion - topic with delete cleanup policy
# tp-workload-compaction - topic with compaction
# tp-workload-fast - topic with fast partition movements enabled
if with_iceberg and mixed_versions:
self.should_skip = True
self.logger.info(
"Skipping test with iceberg and mixed versions as it is not supported"
)
if with_iceberg:
if mixed_versions:
self.should_skip = True
self.logger.info(
"Skipping test with iceberg and mixed versions as it is not supported"
)
cloud_storage_types = supported_storage_types()
if cloud_storage_type not in cloud_storage_types:
self.should_skip = True
self.logger.info(
"Skipping test with iceberg and unsupported cloud storage type"
)

def enable_fast_partition_movement():
if not with_tiered_storage:
Expand Down

0 comments on commit be7d112

Please sign in to comment.