Config apis ACLs #1010
Merged
Config apis ACLs #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both `IncrementalAlterConfigs` and `AlterConfigs` Kafka APIs are very similar in their structure. Added function template that perform authorization for both API types. Signed-off-by: Michal Maslanka <michal@vectorized.io>
Signed-off-by: Michal Maslanka <michal@vectorized.io>
Signed-off-by: Michal Maslanka <michal@vectorized.io>
Signed-off-by: Michal Maslanka <michal@vectorized.io>
mmaslankaprv
force-pushed
the
config-apis-acls
branch
from
f6fa9b2 to
8681bcf
Compare
emaxerrno
reviewed
Apr 1, 2021
| * responsens and modifies passed in group_resources<T> | ||
| */ | ||
| template<typename T, typename R> | ||
| std::vector<R> authorize_alter_config_resources( |
There was a problem hiding this comment.
do we want a quick test for this partitioning function ? how are we thinking of testing this.
There was a problem hiding this comment.
I think we will create a whole suite of tests for authorization
There was a problem hiding this comment.
sounds good, please follow up w/ @dotnwat for the ducktape tests for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
Added missing authorization to describe, alter and incremental alter config Kafka APIs