rpk/start: Reduce startup time #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emaxerrno
previously approved these changes
Apr 17, 2021
0x5d
force-pushed
the
rpk-start-disable-vendor-check
branch
from
b41a97e to
bb1ec2e
Compare
Disable all checks when `--check=false` to reduce startup time. Before: 0.09s user 0.06s system 6% cpu 2.195 total After 0.07s user 0.07s system 13% cpu 1.040 total Measured with: time rpk redpanda start --check=false -- --unknown-rp-flag --unknown-rp-flag is passed so redpanda exits upon encountering an invalid flag.
0x5d
force-pushed
the
rpk-start-disable-vendor-check
branch
from
bb1ec2e to
87d06c1
Compare
emaxerrno
approved these changes
Apr 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable all checks when
--check=falseto reduce startup time.Before:
0.09s user 0.06s system 6% cpu 2.195 total
After
0.07s user 0.07s system 13% cpu 1.040 total
Measured with:
--unknown-rp-flag is passed so redpanda exits upon encountering an invalid flag.
Fixes: #1158