Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ducktape: add transaction tests for transforms #15178

Merged
merged 3 commits into from
Nov 30, 2023
Merged

ducktape: add transaction tests for transforms #15178

merged 3 commits into from
Nov 30, 2023

Conversation

rockwotj
Copy link
Contributor

Add automated tests that transforms only process read committed records.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.2.x
  • v23.1.x
  • v22.3.x

Release Notes

  • none

@rockwotj
Copy link
Contributor Author

Local run of these tests:

SESSION REPORT (ALL TESTS)
ducktape version: 0.8.18
session_id:       2023-11-28--002
run time:         144 minutes 12.774 seconds
tests run:        512
passed:           512
flaky:            0
failed:           0
ignored:          0
opassed:          0
ofailed:          0

@rockwotj
Copy link
Contributor Author

/ci-repeat 4
skip-redpanda-build
skip-unit
dt-repeat=128
tests/rptest/tests/data_transforms_test.py

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Nov 28, 2023 •
edited
Loading

new failures in https://buildkite.com/redpanda/redpanda/builds/41890#018c17eb-df26-428a-895f-617855793f00:

"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=False"

new failures in https://buildkite.com/redpanda/redpanda/builds/41890#018c17eb-df1a-4d22-9d03-00cee0bea692:

"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"

new failures in https://buildkite.com/redpanda/redpanda/builds/41890#018c17eb-df1b-4e55-a957-607808c91af1:

"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"

new failures in https://buildkite.com/redpanda/redpanda/builds/41890#018c17eb-df1b-4ff9-8001-afcf2c7791e4:

"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"

new failures in https://buildkite.com/redpanda/redpanda/builds/41890#018c17eb-df1b-4c82-b236-0f8fdcda2f86:

"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"

new failures in https://buildkite.com/redpanda/redpanda/builds/41954#018c1be8-cfc7-45b5-8493-156264612149:

"rptest.tests.audit_log_test.AuditLogTestsAppLifecycle.test_drain_on_audit_disabled"

new failures in https://buildkite.com/redpanda/redpanda/builds/41988#018c1cf6-2260-49ef-9606-037c2fea6ddb:

"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"

new failures in https://buildkite.com/redpanda/redpanda/builds/41988#018c1cf6-2260-4d44-9e2f-2daf5cec5f67:

"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"

new failures in https://buildkite.com/redpanda/redpanda/builds/41988#018c1cf6-2260-484a-9d69-a524d02634ea:

"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"

new failures in https://buildkite.com/redpanda/redpanda/builds/41988#018c1cf6-225f-4306-bc87-7f8203617419:

"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"
"rptest.tests.data_transforms_test.DataTransformsTest.test_identity.transactional=True"

new failures in https://buildkite.com/redpanda/redpanda/builds/42028#018c1f64-6ae5-4025-9329-b1b4ba79d496:

"rptest.tests.redpanda_kerberos_test.RedpandaKerberosRulesTesting.test_kerberos_mapping_rules.rules=.RULE.1.1test.0.client.DEFAULT.kerberos_principal=client.rp_user=clienttestEXAMPLE.COM.expected_topics=.restricted.always_visible.acl=.restricted.clienttestEXAMPLE.COM.always_visible"

new failures in https://buildkite.com/redpanda/redpanda/builds/42028#018c1f64-6af0-406d-8165-c91787acdd42:

"rptest.tests.redpanda_kerberos_test.RedpandaKerberosTest.test_init.req_principal=client.acl=True.topics=.needs_acl.always_visible.fail=False"
"rptest.tests.redpanda_kerberos_test.RedpandaKerberosConfigTest.test_non_default"

new failures in https://buildkite.com/redpanda/redpanda/builds/42028#018c1f64-6aed-4086-bf1e-9a245d80f86b:

"rptest.tests.redpanda_kerberos_test.GSSAPIReauthTest.test_gssapi_reauth"
"rptest.tests.redpanda_kerberos_test.RedpandaKerberosTest.test_init.req_principal=client.acl=False.topics=.always_visible.fail=False"

new failures in https://buildkite.com/redpanda/redpanda/builds/42028#018c1f64-6ae9-476a-b086-84d73d9c55ea:

"rptest.tests.redpanda_kerberos_test.RedpandaKerberosRulesTesting.test_kerberos_mapping_rules.rules=.RULE.2.1testbad.0.client.RULE.1.1testgood.client.s.client.1redpanda.U.DEFAULT.kerberos_principal=client.rp_user=TESTGOODREDPANDA.expected_topics=.restricted.always_visible.acl=.restricted.TESTGOODREDPANDA.always_visible"

@rockwotj
Copy link
Contributor Author

CI Failures are being addressed by #15187 and d12c892

@rockwotj
Copy link
Contributor Author

Force push: fix formatting

@rockwotj rockwotj mentioned this pull request Nov 29, 2023
Closed
@rockwotj
Copy link
Contributor Author

/ci-repeat 4
skip-redpanda-build
skip-unit
dt-repeat=128
tests/rptest/tests/data_transforms_test.py

@rockwotj rockwotj mentioned this pull request Nov 29, 2023
Closed
@rockwotj
Copy link
Contributor Author

/ci-repeat 4
skip-redpanda-build
skip-unit
dt-repeat=128
tests/rptest/tests/data_transforms_test.py

1 similar comment
@rockwotj
Copy link
Contributor Author

/ci-repeat 4
skip-redpanda-build
skip-unit
dt-repeat=128
tests/rptest/tests/data_transforms_test.py

@rockwotj
ducktape: add transaction tests for transforms
8a6d24a 
Add automated tests that transforms only process read committed records.

Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
@rockwotj
ducktape: handle /stop request failures
1ccd1b7 
I saw a test fail when CI repeating a bunch due to the a retry failing
because the process already had exited, that should be fine, so just
continuing to check that the pid is gone.

Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
@rockwotj
Copy link
Contributor Author

Force push: drop UBSAN in ducktape, that needs a followup PR

@rockwotj
Copy link
Contributor Author

Force push: rebase against dev

@rockwotj
transform/processor: fix overflow
2b50891 
When computing initial lag, it's possible that last_processed_offset is
offset::min(), and we'll get overflow when subtracting that from the
current last record in the log.

Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
@vbotbuildovich
Copy link
Collaborator

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/42050#018c2115-25ca-4ad4-8199-08ec4492a1fe

@rockwotj
Copy link
Contributor Author

/ci-repeat 4
skip-redpanda-build
skip-unit
dt-repeat=128
tests/rptest/tests/data_transforms_test.py

@rockwotj rockwotj requested review from dotnwat and oleiman November 30, 2023 22:29
@rockwotj
Copy link
Contributor Author

CI looks clean after a few hundred runs of the new tests

@rockwotj rockwotj merged commit 53f12fe into redpanda-data:dev Nov 30, 2023
20 checks passed
@rockwotj rockwotj deleted the wasm-txn branch December 1, 2023 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotnwat dotnwat dotnwat approved these changes

@oleiman oleiman Awaiting requested review from oleiman

Assignees
No one assigned
Labels
area/redpanda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rockwotj @vbotbuildovich @dotnwat