[v23.3.x] cluster/config_manager: use property's main name in store_delta #15734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prevents a proprety set via alias and main name to appear twice in the _raw_values map. also take care of cleaning up aliases in the map. this can happen when reusing a snapshot during an upgrade scenario, where an old property becomes an alias of a new property (cherry picked from commit 3e428ba)
andijcr
approved these changes
Dec 18, 2023
|
/dt |
|
issue should be in theory already fixed with #15426 it's strange to see it happen but it's a shutdown exception unrelated to this pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #15725
Fixes: #15733,