-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v23.2.x] admin: stream more json results #16747
Merged
michael-redpanda
merged 3 commits into
v23.2.x
from
vbotbuildovich/backport-16551-v23.2.x-297
Feb 28, 2024
Merged
[v23.2.x] admin: stream more json results #16747
michael-redpanda
merged 3 commits into
v23.2.x
from
vbotbuildovich/backport-16551-v23.2.x-297
Feb 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current approach can lead to an oversized allocation. This is not a full solution as get_leaders needs to not be prone to reactor stalls and oversized allocs. Signed-off-by: Tyler Rockwood <rockwood@redpanda.com> (cherry picked from commit 34d9ec9)
Signed-off-by: Tyler Rockwood <rockwood@redpanda.com> (cherry picked from commit 2818c02)
/dt |
BenPope
previously approved these changes
Feb 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
michael-redpanda
dismissed
BenPope’s stale review
February 27, 2024 16:50
Missing a line in the backport
Signed-off-by: Tyler Rockwood <rockwood@redpanda.com> (cherry picked from commit 3b0ef74)
michael-redpanda
force-pushed
the
vbotbuildovich/backport-16551-v23.2.x-297
branch
from
February 27, 2024 16:54
c94fdf9
to
2dcc64d
Compare
Force push
|
/dt |
BenPope
approved these changes
Feb 28, 2024
CI Failure:
|
michael-redpanda
deleted the
vbotbuildovich/backport-16551-v23.2.x-297
branch
February 28, 2024 18:56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #16551
Fixes: #16716