Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v23.3.x] Enable large alloc warnings above 128KiB by default #16844

Merged
merged 2 commits into from
Mar 2, 2024
Merged

[v23.3.x] Enable large alloc warnings above 128KiB by default #16844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1926f5
node_config: Enable large alloc warnings above 128KiB by default
StephanDollberg Mar 1, 2024
6fbbeb6
tests: Remove explicit setting of large alloc threshold
StephanDollberg Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/v/config/node_config.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ node_config::node_config() noexcept
"memory_allocation_warning_threshold",
"Enables log messages for allocations greater than the given size.",
{.visibility = visibility::tunable},
std::nullopt)
128_KiB + 1) // 128 KiB is the largest allowed allocation size
, storage_failure_injection_enabled(
*this,
"storage_failure_injection_enabled",
Expand Down
10 changes: 1 addition & 9 deletions tests/rptest/services/redpanda.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3145,12 +3145,6 @@ def write_node_conf_file(self,
except:
cur_ver = None

# This node property isn't available on versions of RP older than 23.2.
if cur_ver and cur_ver >= (23, 2, 0):
memory_allocation_warning_threshold_bytes = 256 * 1024 # 256 KiB
else:
memory_allocation_warning_threshold_bytes = None

conf = self.render("redpanda.yaml",
node=node,
data_dir=RedpandaService.DATA_DIR,
Expand All @@ -3169,9 +3163,7 @@ def write_node_conf_file(self,
superuser=self._superuser,
sasl_enabled=self.sasl_enabled(),
endpoint_authn_method=self.endpoint_authn_method(),
auto_auth=self._security.auto_auth,
memory_allocation_warning_threshold=
memory_allocation_warning_threshold_bytes)
auto_auth=self._security.auto_auth)

if override_cfg_params or node in self._extra_node_conf:
doc = yaml.full_load(conf)
Expand Down
3 changes: 0 additions & 3 deletions tests/rptest/services/templates/redpanda.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@ redpanda:
data_directory: "{{data_dir}}"
{% if node_id is not none %}
node_id: {{node_id}}
{% endif %}
{% if memory_allocation_warning_threshold is not none %}
memory_allocation_warning_threshold: {{memory_allocation_warning_threshold}}
{% endif %}
rpc_server:
address: "{{node.account.hostname}}"
Expand Down
Loading