[v23.3.x] storage: fix windowed compaction error handling #16940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to be used by the next commit.
The staging file was missing a '.'. Note that these files are transient, so there isn't a compactibility concern here. (cherry picked from commit 62fd4f8)
CONFLICT: - kept default value for segment_last_offset in compaction_reducers An upcoming test will inject an exception to simulate a failure case seen in the wild that is otherwise hard to reproduce. I'd considered using the file_sanitizer-based error injection, but it seems that infra only really shines at making Redpanda hit asserts, so it's not quite what I'm looking for (my upcoming test will assert that we _don't_ crash in a particular error scenario). (cherry picked from commit 13f5537)
This will be useful to test methods that need a feature table (e.g. deduplicate_segments() has a feature table as an argument). (cherry picked from commit 958aaf7)
We were previously using the l-value-variant of model::record_batch_reader::consume(), which doesn't have a built-in call to finally(). For a log_reader, this meant that in some scenarios (e.g. if the reducer were to fail) we could end up not calling finally(), and therefore wouldn't clear the underlying segment reader. This is exactly what happened, as we hit: std::runtime_error (lz4f_compressend:ERROR_dstMaxSize_tooSmall) errors as we compressed/decompressed batches, and then ultimately crashed because the log_reader was not closed: Assert failure: (.../redpanda/redpanda/src/v/storage/log_reader.h:141) '!_iterator.reader' log reader destroyed with live reader" (cherry picked from commit cc06447)
|
CI failures: |
dotnwat
approved these changes
Mar 8, 2024
| return with_extension("log.compaction.compaction_index"); | ||
| return with_extension(".log.compaction.compaction_index"); |
There was a problem hiding this comment.
does the affect the ability of storage to clean-up the transient files? i'm not sure what kind of wildcard / pattern it uses to identify them.
There was a problem hiding this comment.
It would if we cleaned up leftover files at start up, but I don't think we do currently. We only clean them up at runtime after we compact
There was a problem hiding this comment.
Good to merge? If so, please do. It's a thrill :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #16928
Fixes #16937
Also pulls in 5ad9e14
CONFLICT:
We were previously using the l-value-variant of
model::record_batch_reader::consume(), which doesn't have a built-in
call to finally(). For a log_reader, this meant that in some scenarios
(e.g. if the reducer were to fail) we could end up not calling
finally(), and therefore wouldn't clear the underlying segment reader.
This is exactly what happened, as we hit:
std::runtime_error (lz4f_compressend:ERROR_dstMaxSize_tooSmall)
errors as we compressed/decompressed batches, and then ultimately
crashed because the log_reader was not closed:
Assert failure: (.../redpanda/redpanda/src/v/storage/log_reader.h:141) '!_iterator.reader' log reader destroyed with live reader"
Backports Required
Release Notes
Bug Fixes