Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transform-sdk/go: add support for multiple output topics #16978

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

rockwotj
Copy link
Contributor

@rockwotj rockwotj commented Mar 8, 2024

Add support for the new method to write options in v2 of the broker's
ABI. This includes specifying write options in the RecordWriter
interface that can then be used to call the new writeRecordWithOptions
method with the specified topic name.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x

Release Notes

Features

  • The golang transform-sdk gains the ability to write to multiple output topics.
    This feature can only be used in Redpanda v24.1.x or newer.

@github-actions github-actions bot added the area/wasm WASM Data Transforms label Mar 8, 2024
@rockwotj rockwotj force-pushed the golang-sdk-mot branch 3 times, most recently from 344efa0 to 3386667 Compare March 11, 2024 18:54
@rockwotj rockwotj self-assigned this Mar 11, 2024
@rockwotj rockwotj requested a review from oleiman March 11, 2024 19:55
@rockwotj
Copy link
Contributor Author

@redpanda-data/documentation requesting a review for updates to data transforms SDK. The relevant changes are in src/transform-sdk/go/transform/sdk.go

@rockwotj rockwotj requested a review from a team March 11, 2024 20:54
oleiman
oleiman previously approved these changes Mar 13, 2024
Copy link
Member

@oleiman oleiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems legit

src/transform-sdk/go/transform/doc.go Show resolved Hide resolved
src/transform-sdk/go/transform/sdk.go Outdated Show resolved Hide resolved
Add support for the new method to write options in v2 of the broker's
ABI. This includes specifying write options in the RecordWriter
interface that can then be used to call the new writeRecordWithOptions
method with the specified topic name.

Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
@rockwotj
Copy link
Contributor Author

Force push: fix godoc

@rockwotj rockwotj requested a review from oleiman March 13, 2024 13:53
@rockwotj rockwotj merged commit 9631be1 into redpanda-data:dev Mar 13, 2024
15 checks passed
@rockwotj rockwotj deleted the golang-sdk-mot branch March 13, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/wasm WASM Data Transforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants