Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v23.3.x] Fix a segfault when recovery mode is partially enabled #17022

Merged
merged 2 commits into from
Mar 14, 2024
Merged

[v23.3.x] Fix a segfault when recovery mode is partially enabled #17022

merged 2 commits into from
Mar 14, 2024

Conversation

vbotbuildovich
Copy link
Collaborator

Backport of PR #17013

ztlpn added 2 commits March 12, 2024 17:55
@ztlpn @vbotbuildovich
c/cloud_metadata: fail rpc requests if services are not initialized
a99899b 
Previously these requests resulted in segfaults.

(cherry picked from commit 37fd3e5)
@ztlpn @vbotbuildovich
tests/recovery_mode: add a rolling restart test
d5cc922 
Mostly this test is a smoke test for mixed recovery mode - nodes should
successfully restart and not segfault.

(cherry picked from commit 9388b30)
@vbotbuildovich vbotbuildovich added this to the v23.3.x-next milestone Mar 12, 2024
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Mar 12, 2024
@vbotbuildovich vbotbuildovich requested a review from ztlpn March 12, 2024 17:56
@piyushredpanda piyushredpanda merged commit 378d982 into redpanda-data:v23.3.x Mar 14, 2024
18 checks passed
@ztlpn
Copy link
Contributor

ztlpn commented Mar 14, 2024

Haha thanks @piyushredpanda totally forgot to merge it!

@piyushredpanda
Copy link
Contributor

Haha thanks @piyushredpanda totally forgot to merge it!

It's a thrill to merge. I am happy to do it, any time :D

@BenPope BenPope modified the milestones: v23.3.x-next, v23.3.8 Mar 15, 2024
@github-actions github-actions bot mentioned this pull request Mar 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ztlpn ztlpn ztlpn approved these changes

Assignees
No one assigned
Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Milestone
v23.3.8
Development

Successfully merging this pull request may close these issues.
4 participants
@vbotbuildovich @ztlpn @piyushredpanda @BenPope