-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RBAC: /v1/security/roles/{role}/members #17153
Conversation
/dt |
8a1cbd6
to
36cf534
Compare
new failures in https://buildkite.com/redpanda/redpanda/builds/46341#018e4f8c-398c-4f3d-9e67-e129de0ce4f2:
new failures in https://buildkite.com/redpanda/redpanda/builds/46341#018e4f9e-7a49-42d2-9f55-32d1ff22a9dd:
new failures in https://buildkite.com/redpanda/redpanda/builds/46441#018e5879-fb17-4484-962c-ccdfb80b4f06:
|
ffd6623
to
8b4ec12
Compare
8b4ec12
to
e1bd29d
Compare
force push to uncoroutineify route handler lambda |
e1bd29d
to
20fecc0
Compare
force push missing error codes in member list parse helper and added tests for various malformed requests |
20fecc0
to
d73149a
Compare
force push to fix stale unit test case (s/user/User/) |
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/46417#018e54b4-665d-4217-8596-599fc39493b9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise lgtm
- s/user/User/ for principal_type enum - Adjust `operator<<(..., role_member_type)` in kind - Add missing `create` flag to update_role_members spec Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
d73149a
to
55090bd
Compare
force push rebase dev for merge conflict |
55090bd
to
8003644
Compare
force push review comments |
- GET /v1/security/roles/{role}/members - operationID: list_role_members - POST /v1/security/roles/{role}/members - operationID: update_role_members Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
Introduce: - RoleMember - RoleMemberList - RoleMemberUpdateResponse And integrate into Admin.update_role_members. Includes a minor refactor to Admin._request query param passing. Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
8003644
to
7d94c96
Compare
force push missed a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This PR implements the members Admin endpoint for roles.
Closes https://github.com/redpanda-data/core-internal/issues/1108
Closes https://github.com/redpanda-data/core-internal/issues/1109
Backports Required
Release Notes
Features
/v1/security/roles/{role}/members
Admin API endpoint for reading and updating RBAC role members.