[v23.3.x] cluster: initialize eviction stm for tx coordinator

[andrwng]

We previously didn't register the eviction stm before returning from
partition creation of tx coordinator partitions. This meant that despite
the efforts of storage housekeeping and space management, tx coordinator
partitions would never evict data.

NOTE: this bug[1] doesn't exist on dev, but does in v23.3, and not in v23.2[2].

[1]

redpanda/src/v/cluster/partition.cc

Lines 446 to 471 in 3ce012f

	if (is_tx_manager_topic(_raft->ntp()) && _is_tx_enabled) {
	_tm_stm = builder.create_stm<cluster::tm_stm>(
	clusterlog,
	_raft.get(),
	_feature_table,
	_tm_stm_cache_manager.local().get(_raft->ntp().tp.partition));
	_raft->log()->stm_manager()->add_stm(_tm_stm);
	co_return co_await _raft->start(std::move(builder));
	}
	if (is_transform_offsets_topic(_raft->ntp())) {
	vassert(
	topic_cfg.has_value(),
	"No topic configuration passed, stm requires configuration for "
	"partition count.");
	_transform_offsets_stm = builder.create_stm<transform_offsets_stm_t>(
	topic_cfg->partition_count, clusterlog, _raft.get());
	}
	/**
	* Data partitions
	*/
	if (!storage::deletion_exempt(_raft->ntp())) {
	_log_eviction_stm = builder.create_stm<cluster::log_eviction_stm>(
	_raft.get(), clusterlog, _kvstore);
	_raft->log()->stm_manager()->add_stm(_log_eviction_stm);
	}

[2]

redpanda/src/v/cluster/partition.cc

Lines 79 to 94 in f1216cd

	} else if (is_tx_manager_topic(_raft->ntp())) {
	if (
	_raft->log_config().is_collectable()
	&& !storage::deletion_exempt(_raft->ntp())) {
	_log_eviction_stm = ss::make_shared<cluster::log_eviction_stm>(
	_raft.get(), clusterlog, _as, _kvstore);
	stm_manager->add_stm(_log_eviction_stm);
	}
	if (_is_tx_enabled) {
	auto tm_stm_cache = _tm_stm_cache_manager.local().get(
	_raft->ntp().tp.partition);
	_tm_stm = ss::make_shared<cluster::tm_stm>(
	clusterlog, _raft.get(), feature_table, tm_stm_cache);
	stm_manager->add_stm(_tm_stm);
	}

Includes a backport of #17379
Partially includes a backport of #15424 for testing

Backports Required

• none - not a bug fix
• none - this is a backport
• none - issue does not exist in previous branches
• none - papercut/not impactful enough to backport
• v23.3.x
• v23.2.x

Release Notes

Bug Fixes

• Fixes a bug that would prevent the transaction coordinator topic from reclaiming disk space.

[andrwng]

Force push: pulled in some of #15424 to be able to get the tm_stm in the test