Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

admin/debug/leader_info: prevent reactor stalls #17473

Merged
merged 1 commit into from
Apr 2, 2024
Merged

admin/debug/leader_info: prevent reactor stalls #17473

merged 1 commit into from
Apr 2, 2024

Conversation

rockwotj
Copy link
Contributor

On a many topic/partition cluster this could lead to reactor stalls,
instead use the async version. This does mean that we could fail due to
concurrent modification, so return a 503 in that case to signal a retry.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x

Release Notes

Bug Fixes

  • Prevent reactor stalls querying leadership information for large clusters

@rockwotj rockwotj force-pushed the asyncify branch 3 times, most recently from 66832f6 to 5ea57b1 Compare March 29, 2024 19:57
@rockwotj
admin/debug/leader_info: prevent reactor stalls
7879dc2 
On a many topic/partition cluster this could lead to reactor stalls,
instead use the async version. This does mean that we could fail due to
concurrent modification, so return a 503 in that case to signal a retry.

Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
@vbotbuildovich
Copy link
Collaborator

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/47108#018e8db7-990e-4b72-bfc6-563256f7af7b

@dotnwat dotnwat requested a review from ztlpn April 1, 2024 21:44
pgellert
pgellert approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@pgellert pgellert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rockwotj rockwotj merged commit 126bf56 into redpanda-data:dev Apr 2, 2024
17 checks passed
@vbotbuildovich
Copy link
Collaborator

/backport v23.3.x

@vbotbuildovich
Copy link
Collaborator

Failed to create a backport PR to v23.3.x branch. I tried:

git remote add upstream https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-17473-v23.3.x-785 remotes/upstream/v23.3.x
git cherry-pick -x 7879dc20333ee2daa7b50e6a2a2826eb4b9bfe20

Workflow run logs.

@vbotbuildovich vbotbuildovich mentioned this pull request Apr 2, 2024
Closed
@rockwotj rockwotj deleted the asyncify branch April 2, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgellert pgellert pgellert approved these changes

@michael-redpanda michael-redpanda Awaiting requested review from michael-redpanda

@ztlpn ztlpn Awaiting requested review from ztlpn

Assignees
No one assigned
Labels
area/redpanda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rockwotj @vbotbuildovich @pgellert