Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v23.3.x] net/tls_probe: Introduce "trust_file_crc32c" metric #17587

Merged

Conversation

vbotbuildovich
Copy link
Collaborator

Backport of PR #17539

oleiman added 2 commits April 3, 2024 16:40
Compute the crc32c checksum on the complete binary contents of the
trust file on certificate creation and reload. Export this value on
the metric iff a trust file is present AND certs are otherwise valid.
Otherwise export 0.

This will be particularly useful for cloud clients who want to verify
the contents of the trust store but don't have direct access to the
filesystem of the host.

(cherry picked from commit 190d798)
@vbotbuildovich vbotbuildovich added this to the v23.3.x-next milestone Apr 3, 2024
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Apr 3, 2024
@vbotbuildovich vbotbuildovich requested a review from oleiman April 3, 2024 16:40
@oleiman oleiman self-assigned this Apr 3, 2024
@oleiman
Copy link
Member

oleiman commented Apr 3, 2024

@oleiman oleiman marked this pull request as draft April 3, 2024 17:20
@oleiman oleiman marked this pull request as ready for review April 5, 2024 02:14
Copy link
Member

@oleiman oleiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean backport, but build will fail due to seastar dependency https://github.com/redpanda-data/vtools/pull/2617

passing build: https://buildkite.com/redpanda/vtools/builds/12725

@rockwotj rockwotj merged commit 93f88bf into redpanda-data:v23.3.x Apr 5, 2024
12 of 16 checks passed
@piyushredpanda piyushredpanda modified the milestones: v23.3.x-next, v23.3.12 Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants