-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v23.3.x] Health report collection improvements #17864
Merged
mmaslankaprv
merged 8 commits into
redpanda-data:v23.3.x
from
mmaslankaprv:vbotbuildovich/backport-17715-v23.3.x-384
Apr 16, 2024
Merged
[v23.3.x] Health report collection improvements #17864
mmaslankaprv
merged 8 commits into
redpanda-data:v23.3.x
from
mmaslankaprv:vbotbuildovich/backport-17715-v23.3.x-384
Apr 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the decommission progress api is present in all the nodes Signed-off-by: Michał Maślanka <michal@redpanda.com> (cherry picked from commit cacb97d)
Signed-off-by: Michal Maslanka <michal@redpanda.com> (cherry picked from commit 5d146b0)
The `get_node_health_request` contained version which wasn't serialized and therefore it wasn't used in the remote nodes. Removed the unused version field Signed-off-by: Michal Maslanka <michal@redpanda.com> (cherry picked from commit a1e9811)
Signed-off-by: Michał Maślanka <michal@redpanda.com> (cherry picked from commit acca9ec)
Signed-off-by: Michał Maślanka <michal@redpanda.com> (cherry picked from commit 7f7484d)
When collecting a remote node report a requester is always querying for the full report without the filter. We may simplify the logic of report collection by deprecating the filter field from the request. This will not influence the backward compatibility as the field is not used anyway and is always empty. Signed-off-by: Michał Maślanka <michal@redpanda.com> (cherry picked from commit ab5a19c)
When node is requesting a local node health report we may use a cached value instead of collecting a new node health report every time. Signed-off-by: Michał Maślanka <michal@redpanda.com> (cherry picked from commit 550a448)
…lth` Signed-off-by: Michał Maślanka <michal@redpanda.com> (cherry picked from commit 0c4439a)
ztlpn
approved these changes
Apr 15, 2024
ci-failure: #8950 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #17715