[v23.3.x] archival: Start housekeeping jobs only on a leader #17917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the housekeeping jobs are enabled in the 'start' method. First the 'sync' method of the archival metadata stm is called. We don't check the result of the 'sync' call which is a mistake. Normally, we're calling 'start' method of the 'ntp_archiver' when the partition is already a leader so this code works as expected. But if the partition is moved to another shard we could potentially create and start archiver when the partition is not a leader yet. In this case the 'sync' call returns 'nullopt'. The housekeeping jobs are not enabled because _parent.is_leader() returns 'false' in this case. Then, when the partition becomes a leader the 'notify_leadership' method is invoked. This method enables the housekeeping jobs. The problem is that the 'sync' method of the archival STM may not be called yet. So the adjacent_segment_merger starts reuploading segments based on stale manifest. The fix delays enablement of the housekeeping jobs until the background loop is started and 'sync' is successfully called. The 'notify_leadership' method can enable or disable the jobs after that. (cherry picked from commit 9c37251)
Log all headers in situation when we fail to parse them (cherry picked from commit 426db07)
Increase the timeout and scrubbing frequency. (cherry picked from commit 7747c48)
Lazin
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #17839
Fixes: #17916,