Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kafka: Reduced maximum log line size to 128KiB #17922

Conversation

michael-redpanda
Copy link
Contributor

@michael-redpanda michael-redpanda commented Apr 17, 2024

Fixes: CORE-2409

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x

Release Notes

Bug Fixes

  • Reduces maximum log line size from 1MiB to 128KiB to reduce occurrences of memory allocation failures

Fixes: CORE-2409

Signed-off-by: Michael Boquard <michael@redpanda.com>
@emaxerrno
Copy link
Contributor

this is cool. wondering if there is a global thing we should do anyway. like is there a seastar setting we set in main.cc for all loggers to 128KiB default max msg size.

@michael-redpanda
Copy link
Contributor Author

this is cool. wondering if there is a global thing we should do anyway. like is there a seastar setting we set in main.cc for all loggers to 128KiB default max msg size.

I don't think there is a knob in seastar for that. Everything ends up in a contiguous char[] buffer. We could go through and apply this truncating logger to all of our loggers.

@michael-redpanda michael-redpanda merged commit b6239f3 into redpanda-data:dev Apr 17, 2024
12 of 16 checks passed
@vbotbuildovich
Copy link
Collaborator

/backport v23.3.x

@vbotbuildovich
Copy link
Collaborator

/backport v23.2.x

@emaxerrno
Copy link
Contributor

I don't think there is a knob in seastar for that. Everything ends up in a contiguous char[] buffer. We could go through and apply this truncating logger to all of our loggers.

let's do that, because this will likely happen in other subsystems, for example i imagine the admin api here would be vulnerable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants