[v23.3.x] c/health: reduced number of health_node_report copies #18017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every time the `health_monitor_backend::get_cluster_health` was called we returned a copy of each node health report. The health report data structure maybe large as it contains all partition replica information. To reduce the number of copies while still not interrupting asynchronous iteration over the health report changed the API to return a list of shared pointers. Node health reports aren't modified in place by health monitor backend rather than that they are completely replaced. This makes it easy to share the underlying data without worrying about concurrent access. Signed-off-by: Michał Maślanka <michal@redpanda.com> (cherry picked from commit 226b9bf)
StephanDollberg
approved these changes
Apr 23, 2024
Signed-off-by: Michał Maślanka <michal@redpanda.com>
StephanDollberg
approved these changes
Apr 23, 2024
|
known ci-failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #17863