[v23.3.x] Address oversized allocs across kafka API and schema registry #18053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously used std::vector. The goal here is to avoid oversided allocs in the Kafka API at scale. Adds overrides for several element types, either becuase the conversion was non-trivial (e.g. struct is captured by a lambda that must be copyable) or because the element type is trivially copyable or because we don't expect the container to get very large. Or a combination of those. Additional overrides, in order of definition: - int32_t: std::vector - model::node_id: std::vector - model::partition_id: std::vector - reassignable_partition_response: std::vector - reassignable_partition: std::vector - describe_configs_synonym: std::vector - createable_topic_config: std::vector - creatable_topic_configs: std::vector - creatable_replica_assignment: std::vector - offset_commit_request_partition: std::vector - offset_commit_response_partition: std::vector - offset_commit_request_topic: std::vector - offset_fetch_request_topic: std::vector - partition_produce_response: std::vector - creatable_acl_result: std::vector - listed_group: std::vector - offset_delete_request_partition: std::vector - deletable_group_result: std::vector - delete_acls_matching_acl: std::vector - txn_offset_commit_request_partition: std::vector - txn_offset_commit_request_topic: std::vector - txn_offset_commit_response_partition: std::vector Removed overrides (now covered by chunked_vector default): - creatable_topic: chunked_vector - creatable_topic_configs: chunked_vector - creatable_topic_result: chunked_vector - describe_configs_resource_result: chunked_vector - describe_configs_result: chunked_vector - incremental_alterable_config: chunked_vector - incremental_alter_configs_resource: chunked_vector - alter_configs_resource: chunked_vector - alterable_config: chunked_vector Signed-off-by: Oren Leiman <oren.leiman@redpanda.com> Co-authored-by: Michael Boquard <michael@redpanda.com> (cherry picked from commit 0ef53aa)
And fix a needlessly mutable req_builder (cherry picked from commit 62e5aa9)
Signed-off-by: Michael Boquard <michael@redpanda.com> Signed-off-by: Oren Leiman <oren.leiman@redpanda.com> (cherry picked from commit 3aadeec)
Signed-off-by: Michael Boquard <michael@redpanda.com> Signed-off-by: Oren Leiman <oren.leiman@redpanda.com> (cherry picked from commit 2004a99)
Signed-off-by: Michael Boquard <michael@redpanda.com> Signed-off-by: Oren Leiman <oren.leiman@redpanda.com> (cherry picked from commit 313d208)
michael-redpanda
force-pushed
the
vbotbuildovich/backport-17876-v23.3.x-457
branch
from
583c19c to
66b407a
Compare
oleiman
approved these changes
Apr 24, 2024
|
CI Failure: #17847 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #17876
Fixes: CORE-2641
Fixes: #18047