rm_stm/tests: add test for producer expiration without data batches #18247
Conversation
|
23.3.x backport (with additional fix): #18248 |
| fragmented_vector<model::producer_identity> | ||
| rm_stm::get_expired_producers() const { | ||
| fragmented_vector<model::producer_identity> result; | ||
| auto pids = std::views::keys(_log_state.ongoing_map); |
There was a problem hiding this comment.
are we certain that using std::ranges is now blessed ?
There was a problem hiding this comment.
Judging from https://libcxx.llvm.org/Status/Cxx20.html ranges support should be good in clang 16.
There was a problem hiding this comment.
Though I don't find this any more readable than a for loop :)
There was a problem hiding this comment.
I see references to ranges elsewhere in the code.. I agree it is not any more readable than a range for but opens up possibilities to use std functions like find_if and such.
no logic changes, just refactoring
In earlier versions we were not considering transactions without data batches as candidates for expiry, thats not the case any more with redpanda-data#18076, adding a regression test to future proof.
bharathv
force-pushed
the
add_expiration_test
branch
from
85d75b0 to
565c182
Compare
|
Failure |
|
/backport v24.1.x |
|
/backport v23.3.x |
|
/backport v23.2.x |
|
Failed to create a backport PR to v23.3.x branch. I tried: |
|
Failed to create a backport PR to v23.2.x branch. I tried: |
|
Failed to create a backport PR to v24.1.x branch. I tried: |
In earlier versions we were not considering transactions without data
batches as candidates for expiry, thats not the case any more with
#18076, adding a regression test to future proof.
Backports Required
Release Notes