Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpk: Enable rpk topic describe-storage for internal topics #22338

Merged
merged 2 commits into from
Jul 26, 2024
Merged

rpk: Enable rpk topic describe-storage for internal topics #22338

merged 2 commits into from
Jul 26, 2024

Conversation

r-vasquez
Copy link
Contributor

This PR enables rpk topic describe-storage to work with internal topics

Fixes #21536

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.2.x
  • v24.1.x
  • v23.3.x

Release Notes

Improvements

  • rpk topic describe-storage can be used now with internal topics.

gene-redpanda
gene-redpanda previously approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@gene-redpanda gene-redpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, was gonna ask about the unrelated stuff but saw the commit message.

@r-vasquez
rpk: bump go deps.
741eb50 
It includes updating docker types that were
deprecated.
@r-vasquez r-vasquez force-pushed the describe-storage-internal branch from 68e269c to 741eb50 Compare July 25, 2024 23:48
gene-redpanda
gene-redpanda approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@gene-redpanda gene-redpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deja vu! 👻

@r-vasquez r-vasquez merged commit 68ca607 into redpanda-data:dev Jul 26, 2024
22 checks passed
@vbotbuildovich
Copy link
Collaborator

/backport v24.2.x

@vbotbuildovich
Copy link
Collaborator

Failed to create a backport PR to v24.2.x branch. I tried:

git remote add upstream https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-22338-v24.2.x-314 remotes/upstream/v24.2.x
git cherry-pick -x 966cbacfb09c2d8b8eb8366c8687feb3f8f694db 741eb50322b568f14300bfd9f4fd9e8bf4309f5b

Workflow run logs.

@r-vasquez r-vasquez mentioned this pull request Jul 26, 2024
Merged
7 tasks
@r-vasquez r-vasquez deleted the describe-storage-internal branch October 24, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gene-redpanda gene-redpanda gene-redpanda approved these changes

@twmb twmb Awaiting requested review from twmb twmb is a code owner

@Deflaimun Deflaimun Awaiting requested review from Deflaimun Deflaimun is a code owner

Assignees
No one assigned
Labels
area/rpk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rpk topic describe-storage doesn't show internal topics
3 participants
@r-vasquez @vbotbuildovich @gene-redpanda