[CORE-6807] kafka: change offset_out_of_range condition in replicated_partition::prefix_truncate()
#22905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvartolomei
reviewed
Aug 16, 2024
WillemKauf
force-pushed
the
kafka_delete_records_fix
branch
from
dc8b34a to
a07b6c2
Compare
|
Force push to:
|
nvartolomei
reviewed
Aug 16, 2024
WillemKauf
force-pushed
the
kafka_delete_records_fix
branch
from
a07b6c2 to
568e20f
Compare
|
Force push to address Nicolae's comments:
|
andrwng
reviewed
Aug 16, 2024
Previously, we would return an `error_code::offset_out_of_range` for a request where `kafka_truncation_offset <= start_offset`. This is different behavior from what most Kafka clients are expecting when issuing `DeleteRecords` requests. Change the condition to return early with a `error_code::none` result. Also, correct conditions for tests that would previously expect a truncate call with `offset <= start_offset` to fail with the new, expected behavior (which is success).
Adds a wrapper function around `kafka-delete-records.sh` which can be used to issue `DeleteRecords` requests.
Uses `kafka-delete-records.sh` and `rpk trim-prefix` to assert that Redpanda and Kafka achieve parity for certain edge cases involving `DeleteRecords` requests. Uses both `redpanda` and `KafkaService` brokers as mixins.
WillemKauf
force-pushed
the
kafka_delete_records_fix
branch
from
568e20f to
a3f7130
Compare
|
Force push to address Andrew's comments:
|
nvartolomei
approved these changes
Aug 17, 2024
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/53078#01915dd0-b9b4-42ca-afa9-8e7a381f5281 |
andrwng
approved these changes
Aug 19, 2024
|
/backport v24.2.x |
|
/backport v24.1.x |
dotnwat
reviewed
Aug 20, 2024
oleiman
reviewed
Aug 20, 2024
bharathv
reviewed
Aug 20, 2024
| if ( | ||
| kafka_truncation_offset <= start_offset() | ||
| || kafka_truncation_offset > high_watermark()) { | ||
| if (kafka_truncation_offset <= start_offset()) { |
There was a problem hiding this comment.
nit: https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/cluster/Partition.scala#L1688
suggests that if truncation_offset < 0 it should throw a OffsetOutOfRangeException(), its an edge case so probably not a big deal.
There was a problem hiding this comment.
Ah, there is even more nuance here than that: -1 indicates a complete wipe up to high_watermark, while other values < 0 are an offset_out_of_range error. Will have this covered in a follow up 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would return an
error_code::offset_out_of_rangefor a request wherekafka_truncation_offset <= start_offset.This is a divergence from the current Kafka behaviour, and can lead to errors with certain Kafka clients/consumers.
Remove the condition that throws an
offset_out_of_rangeerror ifkafka_truncation_offset <= start_offset(), instead returningerror_code::none.More context and details in the JIRA link below.
JIRA Link: https://redpandadata.atlassian.net/browse/CORE-6807
Backports Required
Release Notes
Improvements
DeleteRecordsrequests from Kafka clients orrpk topic trim-prefixto be called withtruncation_offset <= start_offsetwithout returning an error. The request is instead treated as a no-op.