chore: upgrade to clang-format-18 #23332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
github-actions
bot
added
area/build
area/redpanda
area/wasm
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
dotnwat
force-pushed
the
clang-format-18-upgrade
branch
from
6c54087 to
d618449
Compare
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
dotnwat
force-pushed
the
clang-format-18-upgrade
branch
from
d618449 to
fc82200
Compare
7 tasks
dotnwat
commented
Sep 16, 2024
Comment on lines
1024
to
+1025
| : _impl(std::make_unique<impl>( | ||
| node_id, pm, gm, api, cache, upload_housekeeping, config)) {} | ||
| node_id, pm, gm, api, cache, upload_housekeeping, config)) {} |
There was a problem hiding this comment.
i appreciate this little indention here, which seems to be a big portion of this overall diff.
Comment on lines
-340
to
+343
| GetParam() ? std::make_optional<remote_label>( | ||
| model::cluster_uuid{uuid_t::create()}) | ||
| : std::nullopt, | ||
| std::nullopt) {} | ||
| GetParam() ? std::make_optional<remote_label>( | ||
| model::cluster_uuid{uuid_t::create()}) | ||
| : std::nullopt, | ||
| std::nullopt) {} |
| : _log(std::move(logger_name)){}; | ||
| : _log(std::move(logger_name)) {}; |
WillemKauf
approved these changes
Sep 17, 2024
andrwng
approved these changes
Sep 17, 2024
BenPope
approved these changes
Sep 17, 2024
tests/java/e2e-verifiers/src/main/java/org/apache/kafka/tools/VerifiableConsumer.java
Show resolved
Hide resolved
Merged
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: upgrade to clang-format-18
Backports Required
Release Notes