Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v24.1.x] CORE-7000: Node ID/UUID Override #23412

Conversation

oleiman
Copy link
Member

@oleiman oleiman commented Sep 20, 2024

Backport of PR #22972

Closes #23404

To enable boost::lexical_cast for program_options parsing and UUIDs in configs.

Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
(cherry picked from commit 9cfd280)

Conflicts:
  src/v/config/conver.h (remove fips/tls serde bits)
- config::node_id_override
- config::node_override_store

Includes json/yaml SerDes and unit tests

Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
(cherry picked from commit dddbe3e)

Conflicts:
  src/v/config/CMakeLists.txt (remove tls_config.cc)
  src/v/config/rjson_serialization.{h,c} (remove fips mode and tls overrides)
  src/v/config/BUILD (removed)
- node_id_overrides: std::vector<config::node_id_override>

Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
(cherry picked from commit 4d573fa)

Conflicts:
  src/v/config/node_config.{h,cc} (remove fips & ossl bits)
  src/v/config/property.h (remove fips & tls bits)
Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
(cherry picked from commit d2b85f2)
Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
(cherry picked from commit c96f4ae)
And wire them into the corresponding node configs.

"--node-id-overrides uuid:uuid:id [uuid:uuid:id ...]"

Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
(cherry picked from commit 951cc77)
and 'restart_nodes'

Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
(cherry picked from commit afe076d)
Signed-off-by: Oren Leiman <oren.leiman@redpanda.com>
(cherry picked from commit ace0d61)
@oleiman oleiman added this to the v24.1.x-next milestone Sep 20, 2024
@oleiman oleiman added the kind/backport PRs targeting a stable branch label Sep 20, 2024
@oleiman oleiman marked this pull request as ready for review September 20, 2024 21:37
@oleiman oleiman requested a review from a team as a code owner September 20, 2024 21:37
@oleiman oleiman self-assigned this Sep 20, 2024
@oleiman oleiman requested review from a team, BenPope and michael-redpanda and removed request for a team September 20, 2024 21:38
@oleiman oleiman marked this pull request as draft September 22, 2024 07:07
@michael-redpanda michael-redpanda marked this pull request as ready for review September 23, 2024 15:50
@oleiman oleiman merged commit 2d3a8af into redpanda-data:v24.1.x Sep 23, 2024
20 checks passed
@BenPope BenPope modified the milestones: v24.1.x-next, v24.1.18 Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants