-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v24.1.x] CORE-7000: Node ID/UUID Override #23412
Merged
oleiman
merged 8 commits into
redpanda-data:v24.1.x
from
oleiman:vbotbuildovich/backport-22972-v24.1.x-514
Sep 23, 2024
Merged
[v24.1.x] CORE-7000: Node ID/UUID Override #23412
oleiman
merged 8 commits into
redpanda-data:v24.1.x
from
oleiman:vbotbuildovich/backport-22972-v24.1.x-514
Sep 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To enable boost::lexical_cast for program_options parsing and UUIDs in configs. Signed-off-by: Oren Leiman <oren.leiman@redpanda.com> (cherry picked from commit 9cfd280) Conflicts: src/v/config/conver.h (remove fips/tls serde bits)
- config::node_id_override - config::node_override_store Includes json/yaml SerDes and unit tests Signed-off-by: Oren Leiman <oren.leiman@redpanda.com> (cherry picked from commit dddbe3e) Conflicts: src/v/config/CMakeLists.txt (remove tls_config.cc) src/v/config/rjson_serialization.{h,c} (remove fips mode and tls overrides) src/v/config/BUILD (removed)
- node_id_overrides: std::vector<config::node_id_override> Signed-off-by: Oren Leiman <oren.leiman@redpanda.com> (cherry picked from commit 4d573fa) Conflicts: src/v/config/node_config.{h,cc} (remove fips & ossl bits) src/v/config/property.h (remove fips & tls bits)
Signed-off-by: Oren Leiman <oren.leiman@redpanda.com> (cherry picked from commit d2b85f2)
Signed-off-by: Oren Leiman <oren.leiman@redpanda.com> (cherry picked from commit c96f4ae)
And wire them into the corresponding node configs. "--node-id-overrides uuid:uuid:id [uuid:uuid:id ...]" Signed-off-by: Oren Leiman <oren.leiman@redpanda.com> (cherry picked from commit 951cc77)
and 'restart_nodes' Signed-off-by: Oren Leiman <oren.leiman@redpanda.com> (cherry picked from commit afe076d)
Signed-off-by: Oren Leiman <oren.leiman@redpanda.com> (cherry picked from commit ace0d61)
oleiman
requested review from
a team,
BenPope and
michael-redpanda
and removed request for
a team
September 20, 2024 21:38
BenPope
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #22972
Closes #23404