Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpk: bring back Makefile and add support for internal topics in describe #23487

Merged
merged 2 commits into from
Sep 27, 2024
Merged

rpk: bring back Makefile and add support for internal topics in describe #23487

merged 2 commits into from
Sep 27, 2024

Conversation

r-vasquez
Copy link
Contributor

@r-vasquez r-vasquez commented Sep 25, 2024 •
edited
Loading

This PR introduces back the Makefile which was removed because it was unmaintained and out dated. This one includes new commands to support the new Bazel build and auto-generation of BUILD files.

Also, cherry-pick the small change from #23397 by @daisukebe which was having problems with the bazel build on the original branch.

$ make  

Usage:
  make <target>

Targets:
    ready               Runs all. Ensures commit is ready.
    build               Build rpk.
    test                Run rpk unit tests.
    tidy                Run go mod tidy.
    lint                Run golangci-lint linter.
    fmt                 Run Gofumpt formatter.
    bazel               Autogenerates BUILD files and resolve bazel dependencies.
    help                Show this help.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.2.x
  • v24.1.x
  • v23.3.x

Release Notes

Improvements

  • --regex flag in rpk topic describe now supports internal topics.

@r-vasquez
rpk: restore Makefile, update with current commands
eb5c237 
This also includes a command for the newly added
bazel commands (autogenerates BUILD files)
rockwotj
rockwotj previously approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@rockwotj rockwotj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bazel commands LGTM

gene-redpanda
gene-redpanda approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@gene-redpanda gene-redpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff

@r-vasquez
Copy link
Contributor Author

Force Push:

  • Added back the help target
  • Removed unnecessary phony targets as there is no collision with filenames.

@r-vasquez r-vasquez merged commit 5cf6dba into redpanda-data:dev Sep 27, 2024
26 checks passed
@vbotbuildovich
Copy link
Collaborator

/backport v24.2.x

@vbotbuildovich
Copy link
Collaborator

/backport v24.1.x

@vbotbuildovich
Copy link
Collaborator

Oops! Something went wrong.

Workflow run logs.

@vbotbuildovich
Copy link
Collaborator

Oops! Something went wrong.

Workflow run logs.

This was referenced Sep 27, 2024
Closed
Closed
@daisukebe daisukebe mentioned this pull request Sep 30, 2024
Closed
7 tasks
@andrewhsu
Copy link
Member

/backport v24.2.x v24.1.x

@vbotbuildovich vbotbuildovich mentioned this pull request Oct 2, 2024
Merged
@andrewhsu
Copy link
Member

/backport v24.1.x

@vbotbuildovich vbotbuildovich mentioned this pull request Oct 2, 2024
Merged
@r-vasquez r-vasquez deleted the rpk-make-misc branch October 22, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gene-redpanda gene-redpanda gene-redpanda approved these changes

@rockwotj rockwotj rockwotj left review comments

@twmb twmb Awaiting requested review from twmb twmb is a code owner

@Deflaimun Deflaimun Awaiting requested review from Deflaimun Deflaimun is a code owner

Assignees
No one assigned
Labels
area/rpk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@r-vasquez @vbotbuildovich @andrewhsu @rockwotj @gene-redpanda