rptest: do not expect cached segment readers at the end of the test #23509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This assertion fails from time to time. It seems perfectly fine there not to be any cached readers available. If there aren't any running queries using readers and we are under memory pressure the next query will likely evict all segment readers to free up resources. Reader eviction (and memory accounting) is asynchronous but the metric/probe update is synchronous. If we get metrics in-between last query acquiring memory resources (or slightly after) and before the actual physical eviction happened then we expect the metric to be 0. It is possible for the last query to be aborted altogether in-between requesting resources and actually creating a reader which would also lead to metric being 0. I consider this acceptable behavior so removing the assert.
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/55206#01922ec3-61cd-4111-b1db-c178db869b90 ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/55206#01922ec3-61d1-476f-9d72-f0e6f35e5f3c ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/55206#01922ec5-6603-4aa9-be00-e5505c3ad115 |
abhijat
approved these changes
Sep 27, 2024
dotnwat
approved these changes
Sep 27, 2024
|
/backport v24.2.x |
|
/backport v24.1.x |
This was referenced Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This assertion fails from time to time. It seems perfectly fine there not to be any cached readers available.
If there aren't any running queries using readers and we are under memory pressure the next query will likely evict all segment readers to free up resources. Reader eviction (and memory accounting) is asynchronous but the metric/probe update is synchronous.
If we get metrics in-between last query acquiring memory resources (or slightly after) and before the actual physical eviction happened then we expect the metric to be 0.
It is possible for the last query to be aborted altogether in-between requesting resources and actually creating a reader which would also lead to metric being 0.
I consider this acceptable behavior so removing the assert.
Backports Required
Release Notes