redpanda: hide kafka server implementation from application.cc #23848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in a separate header, this top-level type allows us to bring the config structure into application.cc without also brining in all of the qdc_monitor implementation itself. Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
dotnwat
force-pushed
the
kafka-server-app
branch
from
98347e9 to
4228989
Compare
dotnwat
commented
Oct 19, 2024
| #include "kafka/server/quota_manager.h" | ||
| #include "kafka/server/rm_group_frontend.h" | ||
| #include "kafka/server/server.h" |
dotnwat
requested review from
andrwng,
oleiman,
michael-redpanda,
rockwotj and
BenPope
and removed request for
andrwng
rockwotj
previously approved these changes
Oct 19, 2024
| server_app& operator=(server_app&&) noexcept = delete; | ||
| ~server_app(); | ||
|
|
||
| seastar::future<> init( |
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
dotnwat
force-pushed
the
kafka-server-app
branch
from
4228989 to
8007461
Compare
|
Forced pushed to add missing interface used in a test. https://github.com/redpanda-data/redpanda/compare/4228989d1281a6bf506c2ee76b38b245372b822b..8007461bdc2fb6a9649ac1ca9c42c81c0187e897 |
rockwotj
approved these changes
Oct 19, 2024
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/56880#0192a5b0-a0a3-4806-aac8-69efbba5ecab |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
redpanda: hide kafka server implementation from application.cc
Backports Required
Release Notes