Add storage_e2e_single_threaded test in bazel #23878
Conversation
travisdowns
changed the title
|
/dt |
| @@ -2356,11 +2356,11 @@ FIXTURE_TEST(changing_cleanup_policy_back_and_forth, storage_test_fixture) { | |||
| } while (disk_log->segments().back()->size_bytes() < size); | |||
| }; | |||
| // add 2 log segments | |||
| add_segment(1_MiB, model::term_id(1)); | |||
|
@dotnwat @rockwotj - this is the same as this other pull #23875 but I somehow managed to push a bad rebase there, dragging in a bunch of folks, so I've just re-opened this here. Diff from that one is that clang-tidy is clean and I depend now on seastar_boost which means I don't need to pull in async.h or tmp_dir.h in a different way. |
|
The test itself is failing with a segfault in the bazel build. Looking into it (it ran for me locally but I was using a different config). |
some tests fail if seastar is started with more than one cpu. in cmake i see |
Yeah I changed this locally to use To get this test in I can probably reduce the logging volume. |
|
I've shelving this for now given that this long-running test has a couple of issues making it unsuitable for integration ATM. |
Add bazel test libraries needed for the storage e2e test: - common - storage_test_fixture - log_gap_analysis Ref CORE-7649.
Fix compile warnings (as errors) which appear only in the bazel build, prior to enabling this test in bazel. Ref CORE-7649.
travisdowns
force-pushed
the
td-e2e-test-in-bazel
branch
2 times, most recently
from
a409406 to
91014fa
Compare
Add the storage_e2e_single_threaded test to the bazel build. Ref CORE-7649.
|
needs i wonder if there is value in running that linter at the end of CI so if you push and walk away you can still come back and see bigger ticket failures if they occur. |
travisdowns
force-pushed
the
td-e2e-test-in-bazel
branch
from
91014fa to
6d82976
Compare
The other side is that it's nice we don't pay the cost of a full CI run if this stuff is broken, because for me I usually check to make sure the big ticket stuff works, but forget to format |
that makes too much sense |
|
I think this one is ready to go in now that CORE-8013 is fixed, it works locally for me anyway! Doing 100 (uncached) iterations just to make sure. |
|
The CMake test doesn't specify any specific amount of memory so I guess the test is getting the entire available memory of the host. This test seems to work fine with the btest amount of 1 MiB, so I left it that way in the bazel version (and this would allow faster test runs due to more parallelism). |
I think it should have been getting 1 GB (cmake_test.py:234) |
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/59502#0193ad5c-6246-48d7-b65c-4c4949761eb1 |
Good call, I forgot about the wrapper. |
Adds the storage_e2e_single_threaded test to the bazel build, including prerequisite work, mostly adding libraries.
Fixes CORE-7649.
Backports Required
Release Notes