samplers: Fix off by one shard id check #23946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanDollberg
force-pushed
the
stephan/mem-sampler-off-by-1-admin
branch
2 times, most recently
from
cea516d to
0f66c05
Compare
StephanDollberg
force-pushed
the
stephan/mem-sampler-off-by-1-admin
branch
from
0f66c05 to
667cb6c
Compare
Fixes an off by one when validating the shard id in both the memory and cpu profiler.
StephanDollberg
force-pushed
the
stephan/mem-sampler-off-by-1-admin
branch
from
35a100f to
4e3aec9
Compare
travisdowns
reviewed
Nov 4, 2024
| if 'shard id too high' in e.response.text.lower(): | ||
| failed = True | ||
|
|
||
| assert failed, "Asking for too high shard id didn't fail" |
There was a problem hiding this comment.
Nice, appreciate the test case.
travisdowns
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an off by one when validating the shard id in both the memory and
cpu profiler.
Backports Required
Release Notes