Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting schema registry configuration parameters via the RPK node config block #24017

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Allow setting schema registry configuration parameters via the RPK node config block #24017

merged 2 commits into from
Nov 7, 2024

Conversation

andrewstucki
Copy link
Contributor

@andrewstucki andrewstucki commented Nov 5, 2024 •
edited by r-vasquez
Loading

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.2.x
  • v24.1.x
  • v23.3.x

Release Notes

Improvements

  • Adds support for setting schema registry connection parameters in the rpk stanza of redpanda.yaml.

@CLAassistant
Copy link

CLAassistant commented Nov 5, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@andrewstucki andrewstucki mentioned this pull request Nov 5, 2024
Merged
@andrewstucki andrewstucki force-pushed the allow-setting-schema-registry-via-rpk-node-config branch from e521d95 to 3dc87d8 Compare November 5, 2024 20:47
@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Nov 5, 2024 •
edited
Loading

the below tests from https://buildkite.com/redpanda/redpanda/builds/57633#0192fe15-c7d4-4a41-8c3b-3a130b26d04e have failed and will be retried

catalog_schema_manager_rpunit

the below tests from https://buildkite.com/redpanda/redpanda/builds/57701#019302fa-32bb-4ba8-8993-60efd2f43440 have failed and will be retried

catalog_schema_manager_rpunit

RafalKorepta
RafalKorepta previously approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@RafalKorepta RafalKorepta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

r-vasquez
r-vasquez approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@r-vasquez r-vasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@vbotbuildovich
Copy link
Collaborator

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/57701#01930355-7074-410b-95cb-16eabc0d698f

@andrewstucki andrewstucki merged commit 5575eaa into dev Nov 7, 2024
28 checks passed
@andrewstucki andrewstucki deleted the allow-setting-schema-registry-via-rpk-node-config branch November 7, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-vasquez r-vasquez r-vasquez approved these changes

@RafalKorepta RafalKorepta RafalKorepta left review comments

@twmb twmb Awaiting requested review from twmb twmb is a code owner

@gene-redpanda gene-redpanda Awaiting requested review from gene-redpanda gene-redpanda is a code owner

@Deflaimun Deflaimun Awaiting requested review from Deflaimun Deflaimun is a code owner

Assignees
No one assigned
Labels
area/rpk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andrewstucki @CLAassistant @vbotbuildovich @RafalKorepta @r-vasquez