Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iceberg: add simple drop_table support for filesystem_catalog #24299

Merged
merged 4 commits into from
Nov 26, 2024

Conversation

ztlpn
Copy link
Contributor

@ztlpn ztlpn commented Nov 26, 2024

This implementation leaves data files as orphans, but is enough for trying iceberg out.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.3.x
  • v24.2.x
  • v24.1.x

Release Notes

  • none

@ztlpn ztlpn added this to the v24.3.1-RC8 milestone Nov 26, 2024
@ztlpn ztlpn force-pushed the iceberg-fs-catalog-delete branch from 1b3a57a to 049dd7d Compare November 26, 2024 01:14
Copy link
Contributor

@bharathv bharathv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ztlpn
Copy link
Contributor Author

ztlpn commented Nov 26, 2024

unrelated bazel failures:

FAIL: //src/v/raft/tests:stm_manager_test (run 1 of 3) (see /root/.cache/bazel/_bazel_root/faeef8fde5e6a20d63d83890c1f75a45/execroot/_main/bazel-out/k8-fastbuild/testlogs/src/v/raft/tests/stm_manager_test/run_1_of_3/test.log)
...
FAIL: //src/v/raft/tests:raft_reconfiguration_test (run 1 of 3) (see /root/.cache/bazel/_bazel_root/faeef8fde5e6a20d63d83890c1f75a45/execroot/_main/bazel-out/k8-fastbuild/testlogs/src/v/raft/tests/raft_reconfiguration_test/run_1_of_3/test.log)

@rockwotj rockwotj merged commit 65b4186 into redpanda-data:dev Nov 26, 2024
14 of 17 checks passed
@vbotbuildovich
Copy link
Collaborator

/backport v24.3.x

@vbotbuildovich
Copy link
Collaborator

Failed to create a backport PR to v24.3.x branch. I tried:

git remote add upstream https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-24299-v24.3.x-690 remotes/upstream/v24.3.x
git cherry-pick -x 3476abdfc6 2b469d146c 5cf96dfb37 049dd7d4a4

Workflow run logs.

@rockwotj
Copy link
Contributor

/backport v24.3.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants