Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rptest] Fix "ContainerAlreadyExists" in test_recovery_mode #24501

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

clee
Copy link
Contributor

@clee clee commented Dec 9, 2024

Occasionally, rptest/tests/recovery_mode_test.py::RecoveryModeTest.test_recovery_mode fails with an Azure storage "container already exists" error. If we try to create a container but it already exists, we should just treat that as a victory and move on instead of failing the test.

Further digging revealed that test_recovery_mode is actually calling RedpandaService.start() twice per test execution, and the second execution explains why the Azure storage bucket/container name "already existed" - it was created by the first call to RedpandaService.start()

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.3.x
  • v24.2.x
  • v24.1.x

Release Notes

  • none

@clee clee requested review from ivotron, gousteris and rpdevmp and removed request for gousteris December 9, 2024 21:43
@clee clee assigned andrewhsu and unassigned andrewhsu Dec 9, 2024
@clee clee requested a review from andrewhsu December 9, 2024 21:44
@clee clee changed the title [rptest] Treat Azure ContainerAlreadyExists as nonfatal [rptest] Fix "ContainerAlreadyExists" in test_recovery_mode Dec 10, 2024
@andrewhsu
Copy link
Member

andrewhsu commented Dec 10, 2024

removing self from reviewer because PR already has suitable reviewers, but feel free to add me back if there is something specific needed to review

@andrewhsu andrewhsu removed their request for review December 10, 2024 19:21
@vbotbuildovich
Copy link
Collaborator

non flaky failures in https://buildkite.com/redpanda/redpanda/builds/59557#0193b1e5-a925-4799-b623-6d40ec364726:

"rptest.tests.consumer_group_balancing_test.ConsumerGroupBalancingTest.test_coordinator_nodes_balance"

@vbotbuildovich
Copy link
Collaborator

Retry command for Build#59557

please wait until all jobs are finished before running the slash command

/ci-repeat 1
tests/rptest/tests/consumer_group_balancing_test.py::ConsumerGroupBalancingTest.test_coordinator_nodes_balance

@clee
Copy link
Contributor Author

clee commented Dec 10, 2024

/ci-repeat 1
tests/rptest/tests/consumer_group_balancing_test.py::ConsumerGroupBalancingTest.test_coordinator_nodes_balance

Copy link
Member

@ivotron ivotron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Would be good to launch the test on cdt just to double check all works well there too

@clee clee disabled auto-merge December 11, 2024 20:58
@clee clee enabled auto-merge December 11, 2024 20:58
@clee
Copy link
Contributor Author

clee commented Dec 13, 2024

/cdt
rptest/tests/recovery_mode_test.py::RecoveryModeTest.test_recovery_mode

@clee clee merged commit c3b46f9 into dev Dec 13, 2024
14 of 16 checks passed
@clee clee deleted the DEVPROD-1902 branch December 13, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants