Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpk remote debug bundle: job-id help text change #24569

Merged
merged 1 commit into from
Dec 20, 2024
Merged

rpk remote debug bundle: job-id help text change #24569

merged 1 commit into from
Dec 20, 2024

Conversation

r-vasquez
Copy link
Contributor

This string must be a UUID and it was not clear
in the help text.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.3.x
  • v24.2.x
  • v24.1.x

Release Notes

  • none

gene-redpanda
gene-redpanda previously approved these changes Dec 13, 2024
View reviewed changes
@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Dec 13, 2024 •
edited
Loading

Retry command for Build#59740

please wait until all jobs are finished before running the slash command


/ci-repeat 1
tests/rptest/tests/random_node_operations_test.py::RandomNodeOperationsTest.test_node_operations@{"cloud_storage_type":2,"enable_failures":false,"mixed_versions":false,"with_iceberg":true,"with_tiered_storage":false}
tests/rptest/tests/random_node_operations_test.py::RandomNodeOperationsTest.test_node_operations@{"cloud_storage_type":2,"enable_failures":false,"mixed_versions":false,"with_iceberg":true,"with_tiered_storage":true}
tests/rptest/tests/random_node_operations_test.py::RandomNodeOperationsTest.test_node_operations@{"cloud_storage_type":2,"enable_failures":true,"mixed_versions":false,"with_iceberg":true,"with_tiered_storage":false}
tests/rptest/tests/random_node_operations_test.py::RandomNodeOperationsTest.test_node_operations@{"cloud_storage_type":2,"enable_failures":true,"mixed_versions":false,"with_iceberg":true,"with_tiered_storage":true}
tests/rptest/tests/e2e_shadow_indexing_test.py::EndToEndShadowIndexingTestCompactedTopic.test_compacting_during_leadership_transfer@{"cloud_storage_type":2}
tests/rptest/tests/cloud_retention_test.py::CloudRetentionTest.test_cloud_retention@{"cloud_storage_type":2,"max_consume_rate_mb":20}
tests/rptest/tests/cloud_retention_test.py::CloudRetentionTest.test_cloud_retention@{"cloud_storage_type":2,"max_consume_rate_mb":null}

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Dec 13, 2024 •
edited
Loading

CI test results

test results on build#59740
test_id test_kind job_url test_status passed
rptest.tests.cloud_retention_test.CloudRetentionTest.test_cloud_retention.max_consume_rate_mb=20.cloud_storage_type=CloudStorageType.ABS ducktape https://buildkite.com/redpanda/redpanda/builds/59740#0193c1f3-1005-479e-a236-bd62a9379863 FAIL 0/6
rptest.tests.cloud_retention_test.CloudRetentionTest.test_cloud_retention.max_consume_rate_mb=None.cloud_storage_type=CloudStorageType.ABS ducktape https://buildkite.com/redpanda/redpanda/builds/59740#0193c1f3-1001-4390-a604-48575f09efee FAIL 0/6
rptest.tests.datalake.partition_movement_test.PartitionMovementTest.test_cross_core_movements.cloud_storage_type=CloudStorageType.S3 ducktape https://buildkite.com/redpanda/redpanda/builds/59740#0193c1f1-e56f-44ec-a869-9b77870df112 FLAKY 4/6
rptest.tests.e2e_shadow_indexing_test.EndToEndShadowIndexingTestCompactedTopic.test_compacting_during_leadership_transfer.cloud_storage_type=CloudStorageType.ABS ducktape https://buildkite.com/redpanda/redpanda/builds/59740#0193c1f3-1005-479e-a236-bd62a9379863 FAIL 0/1
rptest.tests.random_node_operations_test.RandomNodeOperationsTest.test_node_operations.enable_failures=False.mixed_versions=False.with_tiered_storage=False.with_iceberg=True.cloud_storage_type=CloudStorageType.ABS ducktape https://buildkite.com/redpanda/redpanda/builds/59740#0193c1f3-1005-479e-a236-bd62a9379863 FAIL 0/1
rptest.tests.random_node_operations_test.RandomNodeOperationsTest.test_node_operations.enable_failures=False.mixed_versions=False.with_tiered_storage=True.with_iceberg=True.cloud_storage_type=CloudStorageType.ABS ducktape https://buildkite.com/redpanda/redpanda/builds/59740#0193c1f3-1005-479e-a236-bd62a9379863 FAIL 0/1
rptest.tests.random_node_operations_test.RandomNodeOperationsTest.test_node_operations.enable_failures=True.mixed_versions=False.with_tiered_storage=False.with_iceberg=True.cloud_storage_type=CloudStorageType.ABS ducktape https://buildkite.com/redpanda/redpanda/builds/59740#0193c1f3-1005-479e-a236-bd62a9379863 FAIL 0/1
rptest.tests.random_node_operations_test.RandomNodeOperationsTest.test_node_operations.enable_failures=True.mixed_versions=False.with_tiered_storage=True.with_iceberg=True.cloud_storage_type=CloudStorageType.ABS ducktape https://buildkite.com/redpanda/redpanda/builds/59740#0193c1f3-1005-479e-a236-bd62a9379863 FAIL 0/1
test results on build#59812
test_id test_kind job_url test_status passed
rptest.tests.cloud_retention_test.CloudRetentionTest.test_cloud_retention.max_consume_rate_mb=None.cloud_storage_type=CloudStorageType.ABS ducktape https://buildkite.com/redpanda/redpanda/builds/59812#0193d06f-8c4c-4b36-a165-e690b8351680 FAIL 0/6

JakeSCahill
JakeSCahill reviewed Dec 15, 2024
View reviewed changes
src/go/rpk/pkg/cli/debug/remotebundle/start.go Outdated
@@ -155,7 +155,7 @@ status, run:
},
}
f := cmd.Flags()
f.StringVar(&jobID, "job-id", "", "ID of the job to start debug bundle in")
f.StringVar(&jobID, "job-id", "", "UUID of the job to start the debug bundle in")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
f.StringVar(&jobID, "job-id", "", "UUID of the job to start the debug bundle in")
f.StringVar(&jobID, "job-id", "", "Custom UUID to assign to the job that generates the debug bundle.")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed, thanks. 👍

Note: I didn't add a period at the end, as we don't add them to the flags' help text.

@r-vasquez
rpk remote debug bundle: job-id help text change
7f8322c 
This string must be a UUID and it was not clear
in the help text.
@vbotbuildovich
Copy link
Collaborator

Retry command for Build#59812

please wait until all jobs are finished before running the slash command

/ci-repeat 1
tests/rptest/tests/cloud_retention_test.py::CloudRetentionTest.test_cloud_retention@{"cloud_storage_type":2,"max_consume_rate_mb":null}

@r-vasquez
Copy link
Contributor Author

^ Unrelated test failure, this is a change in a flag help text, we can merge. Thanks!

@r-vasquez
Copy link
Contributor Author

/ci-repeat 1
tests/rptest/tests/cloud_retention_test.py::CloudRetentionTest.test_cloud_retention@{"cloud_storage_type":2,"max_consume_rate_mb":null}

@r-vasquez
Copy link
Contributor Author

/ci-repeat 1
tests/rptest/tests/cloud_retention_test.py::CloudRetentionTest.test_cloud_retention

@r-vasquez r-vasquez merged commit 732fd5e into redpanda-data:dev Dec 20, 2024
23 checks passed
@vbotbuildovich
Copy link
Collaborator

/backport v24.3.x

@vbotbuildovich vbotbuildovich mentioned this pull request Dec 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeSCahill JakeSCahill JakeSCahill left review comments

@Deflaimun Deflaimun Deflaimun approved these changes

@gene-redpanda gene-redpanda gene-redpanda left review comments

@twmb twmb Awaiting requested review from twmb twmb is a code owner

Assignees
No one assigned
Labels
area/rpk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@r-vasquez @vbotbuildovich @Deflaimun @JakeSCahill @gene-redpanda