Exit early on invariants change #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to make the configuration invariant change detector effective we have to exit early if any of the invariants have changed. Previous approach lead us to the situation in which some services were already started and they accessed invalid configuration causing a segfault. Fixes: redpanda-data#742 Signed-off-by: Michal Maslanka <michal@vectorized.io>
Partition allocator, when updating its internal state, assumes that node with given id exists (this is pre nodes decommissioning). Added vassert validating this assumption. Signed-off-by: Michal Maslanka <michal@vectorized.io>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make the configuration invariant change detector effective we have to exit early if any of the invariants have changed. Previous approach lead us to the situation in which some services were already started and they accessed invalid configuration causing a segfault.
Fixes: #742
Checklist
When referencing a related issue, remember to migrate duplicate stories from the
external tracker. This is not relevant for most users.