Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

js: replace wasm-api library scope #8357

Merged
merged 2 commits into from
Jan 26, 2023

Conversation

sago2k8
Copy link
Contributor

@sago2k8 sago2k8 commented Jan 23, 2023

Update wasm-api npm library from @vectorizedio/wasm-api to @redpanda-data/wasm-api.

This change moves wasm-api to the Redpanda's npm organisation.

Backports Required

  • none - not a bug fix
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v22.3.x
  • v22.2.x
  • v22.1.x

UX Changes

Replace the wasm npm library from @vectorizedio/wasm-api to @redpanda-data/wasm-api.

Release Notes

  • none

fixes https://github.com/redpanda-data/devprod/issues/430

@CLAassistant
Copy link

CLAassistant commented Jan 23, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added area/rpk area/wasm WASM Data Transforms labels Jan 23, 2023
@sago2k8 sago2k8 changed the title js: replace wasm-api library owner js: replace wasm-api library scope Jan 23, 2023
r-vasquez
r-vasquez previously approved these changes Jan 23, 2023
@sago2k8 sago2k8 requested a review from a team as a code owner January 24, 2023 14:57
@sago2k8 sago2k8 requested review from gousteris and removed request for a team January 24, 2023 14:57
@sago2k8
Copy link
Contributor Author

sago2k8 commented Jan 24, 2023

@r-vasquez I updated the release workflow to update node to the nearest lts version.
@ivotron We need to update the NPM_TOKEN secret value to a deployment key from the npm org.
Thanks

Update wasm-api npm library from @vectorizedio/wasm-api to
@redpanda-data/wasm-api.

This change moves wasm-api to the Redpanda's npm organisation.
update version of nodejs to 14.x.x, version 12 is not maintaiened
anymore.

update the actions trigger, even should only trigger on some specific tag
push events.
@sago2k8 sago2k8 force-pushed the update-wasm-api-package-name branch from fc2d310 to 3848387 Compare January 25, 2023 12:56
@ivotron
Copy link
Member

ivotron commented Jan 25, 2023

thanks @sago2k8 , token has been updated

@r-vasquez
Copy link
Contributor

@ivotron Can we merge then, right?

@ivotron
Copy link
Member

ivotron commented Jan 26, 2023

@ivotron Can we merge then, right?

yes, though the bump of node version might break the workflow. since it doesn't run on PRs, only on tags, this will be tested when we release. but let's do it and if it breaks we fix quickly

@ivotron ivotron merged commit 2420032 into redpanda-data:dev Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants